Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency maintenance #70

Closed
wants to merge 1 commit into from
Closed

Conversation

viceice
Copy link
Member

@viceice viceice commented Jun 4, 2024

Updated dependencies according to https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/#currently-recommended-versions

Testing done

run mvn clean verify

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@viceice
Copy link
Member Author

viceice commented Jun 4, 2024

@justusbunsi It seems i'm not allowed to update the java versions 😕

@justusbunsi
Copy link
Member

@justusbunsi It seems i'm not allowed to update the java versions 😕

Seems that Jenkins builds are configured to not trust Jenkinsfile changes from forks. We have to provide a PR from the repo itself with your changes.

16:02:47  Loading trusted files from base branch master at 904c2dba860685fda828ca87bd047d39c99b726e rather than dae7b003c95ff166af242d1dd4fdbdb3a14ddc52
16:02:47  Obtained Jenkinsfile from 904c2dba860685fda828ca87bd047d39c99b726e
16:02:47  ‘Jenkinsfile’ has been modified in an untrusted revision

By the way: Thanks for providing the version bump. 🙂

@viceice
Copy link
Member Author

viceice commented Jun 5, 2024

You could just take the Jenkinsfile change and leave the rest on my PR?

@justusbunsi
Copy link
Member

You could just take the Jenkinsfile change and leave the rest on my PR?

@viceice, in #71 I tried to only apply the Jenkinsfile changes. Turns out, I have to apply all your changes so that the PR build proceed and not break due to incompatibility. Even with all the changes the CI fails because of incorrect JavaDoc creation. I don't know how Windows will behave, it is cancelled every time the Linux stage fails.

Are you ok with me resetting #71 onto your PR commit, mark this one superseded by my PR and continue fixing CI errors there?

@viceice
Copy link
Member Author

viceice commented Jun 15, 2024

sure, go ahead 🤗

@justusbunsi
Copy link
Member

Closing in favor of #71

@viceice viceice deleted the feat/deps-update branch June 20, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants