Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-72788: Un-inlining JS in GitHubPushTrigger/config.groovy #383

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

krystaltt
Copy link
Contributor

See JENKINS-72788.

Testing done

After un-inlining the inline javascript in GitHubPushTrigger/config.groovy, it still can periodically send request to the "checkHookRegistered" endpoint.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@KostyaSha KostyaSha merged commit 56810df into jenkinsci:master Jul 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants