Merge pull request #116 from zhangethan/master

remove useless char "?" at the end of redirect_uri
jenkinsci · Jul 13, 2023 · d6a226f · d6a226f
2 parents ca26368 + 2be2827
commit d6a226f
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/main/java/org/jenkinsci/plugins/GitLabSecurityRealm.java b/src/main/java/org/jenkinsci/plugins/GitLabSecurityRealm.java
@@ -290,10 +290,9 @@ public HttpResponse doCommenceLogin(StaplerRequest request, @QueryParameter Stri
 
     private String buildRedirectUrl(StaplerRequest request) throws MalformedURLException {
         URL currentUrl = new URL(Jenkins.get().getRootUrl());
-        List<NameValuePair> parameters = new ArrayList<>();
 
         URL redirect_uri = new URL(currentUrl.getProtocol(), currentUrl.getHost(), currentUrl.getPort(),
-                request.getContextPath() + "/securityRealm/finishLogin?" + URLEncodedUtils.format(parameters, StandardCharsets.UTF_8));
+                request.getContextPath() + "/securityRealm/finishLogin");
         return redirect_uri.toString();
     }