Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove useless char "?" at the end of redirect_uri #116

Merged
merged 1 commit into from
Jul 13, 2023
Merged

remove useless char "?" at the end of redirect_uri #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/java/org/jenkinsci/plugins/GitLabSecurityRealm.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,10 +290,9 @@

private String buildRedirectUrl(StaplerRequest request) throws MalformedURLException {
URL currentUrl = new URL(Jenkins.get().getRootUrl());
List<NameValuePair> parameters = new ArrayList<>();

URL redirect_uri = new URL(currentUrl.getProtocol(), currentUrl.getHost(), currentUrl.getPort(),
request.getContextPath() + "/securityRealm/finishLogin?" + URLEncodedUtils.format(parameters, StandardCharsets.UTF_8));
request.getContextPath() + "/securityRealm/finishLogin");

Check warning on line 295 in src/main/java/org/jenkinsci/plugins/GitLabSecurityRealm.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered line 

Line 295 is not covered by tests
return redirect_uri.toString();
}

Expand Down Expand Up @@ -509,7 +508,7 @@
/**
*
* @param username
* @throws UsernameNotFoundException

Check warning on line 511 in src/main/java/org/jenkinsci/plugins/GitLabSecurityRealm.java

View check run for this annotation

ci.jenkins.io / JavaDoc

JavaDoc @throws 

NORMAL:
no description for @throws
* @throws DataAccessException
*/
@Override
Expand Down Expand Up @@ -565,7 +564,7 @@
/**
*
* @param groupName
* @throws UsernameNotFoundException

Check warning on line 567 in src/main/java/org/jenkinsci/plugins/GitLabSecurityRealm.java

View check run for this annotation

ci.jenkins.io / JavaDoc

JavaDoc @throws 

NORMAL:
no description for @throws
* @throws DataAccessException
*/
@Override
Expand Down
Loading