Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use checkstyle for Java 11 #123

Merged
merged 2 commits into from
Oct 1, 2023
Merged

Use checkstyle for Java 11 #123

merged 2 commits into from
Oct 1, 2023

Conversation

MarkEWaite
Copy link
Contributor

Use checkstyle for Java 11

  • Use checkstyle 10 now that we require Java 11
  • Label dependabot pull requests

Testing done

The checkstyle output continues silent when I run mvn checkstyle:checkstyle. Will confirm with ci.jenkins.io as well.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite MarkEWaite requested a review from a team as a code owner October 1, 2023 19:03
@MarkEWaite MarkEWaite merged commit 88daaa7 into jenkinsci:master Oct 1, 2023
16 checks passed
@MarkEWaite MarkEWaite deleted the use-checkstyle-for-java-11 branch October 1, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gounthar gounthar gounthar approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkEWaite @gounthar