[JENKINS-66303] Prepare Gitlab Authentication for core Guava upgrade #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mohamedelhabib Would it be possible to take a look at this PR? This would help the Jenkins core developers proceed with the Guava upgrade. |
|
@basil I have a feeling that this project has been abandoned. I have had a pull request pending for what I consider a critical security issue for a while. |
|
@skorhone Since you have a GitLab installation with which to test against, why don't you open a PR at jenkins-infra/repository-permissions-updater to adopt this plugin? Then you can merge and release both your PR and this one. I can be your mentor from the Jenkins community. |
14 tasks
|
Released in 1.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-66303 and JENKINS-65988. Jenkins core is using Guava 11.0.1, which was released on January 9, 2012. Jenkins core would like to upgrade to Guava 30.1.1, which was released on March 19, 2021. Plugins must be prepared to be compatible with both Guava 11.0.1 and Guava 30.1.1 in advance of this core transition.
In particular, this plugin has been identified as using the
com.google.common.cache.Cache#get(K key)API, which has been removed between Guava 11.0.1 and latest. The removal took place in Guava 12.0.To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The recommendation is for plugins to migrate from Guava's cache to Caffeine via the Jenkins Caffeine API plugin.
For the most part, the migration is a trivial matter of replacing imports of
com.google.common.cache.Cachewith imports ofcom.github.benmanes.caffeine.cache.Cacheand imports ofcom.google.common.cache.CacheBuilderwith imports ofcom.github.benmanes.caffeine.cache.Caffeine.Untested.
CC @mohamedelhabib