Add client secret getter for jelly #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Released in 1.15. |
|
@basil thanks, that was fast. For some reason the latest release in update center is still 1.13: https://updates.jenkins.io/download/plugins/gitlab-oauth EDIT never mind, I guess that's fixed now with jenkins-infra/update-center2#581 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amends #59 -- there I removed the getter (assuming it was better not to expose the secret via public method), but it's needed for the Jelly controls to work correctly. Without it, clicking "save" in global configuration without making any changes will store empty secret to config, locking everybody out. Sorry for the mess!
@basil could you please release this soon?