Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gitlab-api plugin #66

Merged
merged 6 commits into from
Apr 18, 2022
Merged

Use gitlab-api plugin #66

merged 6 commits into from
Apr 18, 2022

Conversation

basil
Copy link
Member

@basil basil commented Apr 16, 2022

Using the new gitlab-api plugin from jenkinsci/gitlab-api-plugin#7

It took a while to get this compile. I have not tried to run the code and I do not have a GitLab server to test with.

Anyone interested in testing this? @zbynek perhaps since you submitted some security fixes recently (no pressure, though)? @dcendents since you're doing other GitLab plugin stuff?

@basil basil added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Apr 16, 2022
pom.xml Outdated Show resolved Hide resolved
Co-authored-by: Joseph Petersen <josephp90@gmail.com>
@dcendents
Copy link

@basil I don't use this plugin so it is not easy for me to test either.

@basil basil marked this pull request as ready for review April 18, 2022 17:29
@basil basil merged commit 1b348b6 into jenkinsci:master Apr 18, 2022
@basil basil deleted the gitlab-api branch April 18, 2022 18:34
@basil
Copy link
Member Author

basil commented Apr 18, 2022

Released in 1.16.

@zbynek
Copy link
Contributor

zbynek commented Apr 18, 2022

I installed the RC build from this PR and didn't spot any problems (login/logout worked for me). Will try again with 1.16

@basil
Copy link
Member Author

basil commented Apr 18, 2022

Thanks @zbynek. I installed a toy instance of GitLab this morning and did a basic smoke test, but I don't have a realistic testing environment. Confirmation that this is stable and working would definitely be appreciated!

@zbynek
Copy link
Contributor

zbynek commented Apr 18, 2022

Still works fine with 1.16 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants