Add getter to triggerOnApprovedMergeRequest

[jakub-bochenski]

Fixes #711

[chinhodado]

Can someone merge this please? The issue is annoying.

[jakub-bochenski]

@omehegan @Argelbargel @mreichel the fix is rather simple, can you take a look please?

[lambourn]

would be great if the team could cut a hotfix release that incorporates this fix.

[jakub-bochenski]

@lambourn why don't you try the snapshot build and see if it fixes the issue for you? https://ci.jenkins.io/job/Plugins/job/gitlab-plugin/job/PR-714/1/artifact/target/gitlab-plugin-1.5.4-SNAPSHOT.hpi

[lambourn]

@jakub-bochenski will definitely do, I was not aware there is a snapshot for it.

[chinhodado]

I can confirm the snapshot fixes the issue

Edit: it doesn't, see below.

[williamzhao87]

Can someone merge this if possible? Would be great to have the fix available :)

[chinhodado]

Actually I think it doesn't fix the issue. With the snapshot build, the checkbox for "Approved Merge Requests" is properly cleared when loading the config page, but the build is still triggered when that event happens.

[sulx]

Yea triggerOnApprovedMergeRequest as false it now goes off but still triggers on approval

[pdudits]

I think these are identified as two separate issues. #711 is UI issue, #633 is the actual problem with missing filters for job triggers.

[omehegan]

This was fixed/released in version 1.5.4 of the plugin, which should be available in the update center soon.