Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt tests to updated version of google-oauth-plugin #266

Merged
merged 6 commits into from
Oct 25, 2023

Conversation

aneveux
Copy link
Member

@aneveux aneveux commented Oct 25, 2023

Supersedes #263

Hello 👋

Since jenkinsci/google-oauth-plugin#186, the constructor public GoogleRobotPrivateKeyCredentials(String projectId, ServiceAccountConfig serviceAccountConfig, @Nullable GoogleRobotCredentialsModule module) was deprecated in favor of one allowing to specify explicitly the credential ID.
This PR provides an update in the automated tests making use of the up-to-date constructor.

Testing done

Submitter checklist

Preview Give feedback

Riliane and others added 6 commits October 9, 2023 15:20
do not assume credential id is project id - retrieve the generated credential id
do not assume credential id is project id - retrieve the generated credential id
@jtnord jtnord requested review from jtnord and a team October 25, 2023 14:10
@jtnord jtnord merged commit c9ac797 into jenkinsci:develop Oct 25, 2023
13 checks passed
@jtnord jtnord added the chore label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants