Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enriched build scans #232

Merged
merged 30 commits into from
Feb 6, 2023

Conversation

jprinet
Copy link
Contributor

@jprinet jprinet commented Jan 4, 2023

Enrich Jenkins job summary page with the following build scan data fetched from Gradle Enterprise API:

  • project name
  • requested tasks
  • build tool version
  • build outcome
  • build scan links

The feature is turned off by default and can be enabled and configured through the Jenkins system administration.

Worth noticing that the InjectionConfig has been moved to GlobalConfig

@jprinet jprinet force-pushed the feature/hackathon_enriched_summary branch 2 times, most recently from fb677b5 to 7cdada7 Compare January 5, 2023 17:55
@jprinet jprinet marked this pull request as ready for review January 13, 2023 08:29
@c00ler c00ler self-requested a review January 17, 2023 16:26
@c00ler c00ler added the feature label Jan 17, 2023
Copy link
Contributor

@c00ler c00ler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice feature! The only thing that I find the configuration is a little bit confusing.

  • Do we need the ability to override the API base URL? AFAIK GE API is always a part of the GE, so the base URL is the same. We should be able to take it from the existing configuration parameter. Are there any customers that require an override of the URL?
  • Do we need a separate token to query the API? Shouldn't the already existing token, that we use to publish be enough to also query the details?

README.adoc Show resolved Hide resolved
@jprinet jprinet force-pushed the feature/hackathon_enriched_summary branch from a9d5ee8 to 5a87ba0 Compare January 31, 2023 14:46
@jprinet jprinet force-pushed the feature/hackathon_enriched_summary branch from 7b41175 to a9f65fa Compare February 6, 2023 17:19
@c00ler c00ler merged commit bd58b3d into jenkinsci:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants