-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enriched build scans #232
Merged
c00ler
merged 30 commits into
jenkinsci:master
from
jprinet:feature/hackathon_enriched_summary
Feb 6, 2023
Merged
Enriched build scans #232
c00ler
merged 30 commits into
jenkinsci:master
from
jprinet:feature/hackathon_enriched_summary
Feb 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprinet
force-pushed
the
feature/hackathon_enriched_summary
branch
2 times, most recently
from
January 5, 2023 17:55
fb677b5
to
7cdada7
Compare
c00ler
requested changes
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice feature! The only thing that I find the configuration is a little bit confusing.
- Do we need the ability to override the API base URL? AFAIK GE API is always a part of the GE, so the base URL is the same. We should be able to take it from the existing configuration parameter. Are there any customers that require an override of the URL?
- Do we need a separate token to query the API? Shouldn't the already existing token, that we use to publish be enough to also query the details?
acceptance-tests/src/test/java/hudson/plugins/gradle/AbstractAcceptanceTest.java
Outdated
Show resolved
Hide resolved
acceptance-tests/src/test/java/hudson/plugins/gradle/AbstractAcceptanceTest.java
Outdated
Show resolved
Hide resolved
acceptance-tests/src/test/java/hudson/plugins/gradle/GradleInjectionTest.java
Outdated
Show resolved
Hide resolved
acceptance-tests/src/test/java/hudson/plugins/gradle/MockGeServer.java
Outdated
Show resolved
Hide resolved
src/main/java/hudson/plugins/gradle/enriched/ScanDetailServiceDefaultImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/hudson/plugins/gradle/enriched/ScanDetailServiceDefaultImpl.java
Outdated
Show resolved
Hide resolved
src/main/resources/hudson/plugins/gradle/config/GlobalConfig/config.jelly
Outdated
Show resolved
Hide resolved
src/test/groovy/hudson/plugins/gradle/enriched/ScanDetailTest.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/hudson/plugins/gradle/enriched/ScanDetailTest.groovy
Outdated
Show resolved
Hide resolved
c00ler
reviewed
Jan 30, 2023
acceptance-tests/src/test/java/hudson/plugins/gradle/MockGeServer.java
Outdated
Show resolved
Hide resolved
acceptance-tests/src/test/java/hudson/plugins/gradle/MockGeServer.java
Outdated
Show resolved
Hide resolved
src/main/java/hudson/plugins/gradle/AbstractBuildScanAction.java
Outdated
Show resolved
Hide resolved
src/main/java/hudson/plugins/gradle/enriched/ScanDetailService.java
Outdated
Show resolved
Hide resolved
src/main/java/hudson/plugins/gradle/enriched/ScanDetailService.java
Outdated
Show resolved
Hide resolved
src/main/java/hudson/plugins/gradle/enriched/ScanDetailService.java
Outdated
Show resolved
Hide resolved
src/main/java/hudson/plugins/gradle/enriched/ScanDetailService.java
Outdated
Show resolved
Hide resolved
src/main/java/hudson/plugins/gradle/enriched/ScanDetailService.java
Outdated
Show resolved
Hide resolved
src/main/java/hudson/plugins/gradle/enriched/ScanDetailService.java
Outdated
Show resolved
Hide resolved
src/main/java/hudson/plugins/gradle/enriched/ScanDetailService.java
Outdated
Show resolved
Hide resolved
c00ler
reviewed
Jan 30, 2023
c00ler
reviewed
Jan 30, 2023
src/test/groovy/hudson/plugins/gradle/enriched/ScanDetailServiceDefaultImplTest.groovy
Outdated
Show resolved
Hide resolved
jprinet
force-pushed
the
feature/hackathon_enriched_summary
branch
from
January 31, 2023 14:46
a9d5ee8
to
5a87ba0
Compare
c00ler
reviewed
Feb 1, 2023
src/main/java/hudson/plugins/gradle/enriched/ScanDetailService.java
Outdated
Show resolved
Hide resolved
src/main/java/hudson/plugins/gradle/enriched/ScanDetailService.java
Outdated
Show resolved
Hide resolved
src/main/java/hudson/plugins/gradle/enriched/ScanDetailService.java
Outdated
Show resolved
Hide resolved
c00ler
approved these changes
Feb 6, 2023
jprinet
force-pushed
the
feature/hackathon_enriched_summary
branch
from
February 6, 2023 17:19
7b41175
to
a9f65fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enrich Jenkins job summary page with the following build scan data fetched from Gradle Enterprise API:
The feature is turned off by default and can be enabled and configured through the Jenkins system administration.
Worth noticing that the
InjectionConfig
has been moved toGlobalConfig