Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a class containing the embedded extensions versions #235

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

c00ler
Copy link
Contributor

@c00ler c00ler commented Jan 20, 2023

Generate a class with the embedded extensions versions instead of a property file. Using a class makes a code simpler because versions are defined at compile time and there is no need to load them at runtime.

@c00ler c00ler added the chore label Jan 20, 2023
@c00ler c00ler self-assigned this Jan 20, 2023
Base automatically changed from avenderov/gradle-kotlin-dsl to master January 30, 2023 10:39
@c00ler c00ler force-pushed the avenderov/extensions-versions branch from eaa1a38 to 1e50224 Compare January 30, 2023 12:07
@c00ler c00ler changed the title Generate class containing embedded extensions versions Generate a class containing the embedded extensions versions Jan 30, 2023
@c00ler c00ler marked this pull request as ready for review January 30, 2023 12:19
Copy link
Contributor

@sorin-florea sorin-florea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@c00ler c00ler merged commit c81e1c1 into master Jan 30, 2023
@c00ler c00ler deleted the avenderov/extensions-versions branch January 30, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants