Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gradle Enterprise exceptions log filter #294

Merged
merged 28 commits into from
May 15, 2023
Merged

Conversation

c00ler
Copy link
Contributor

@c00ler c00ler commented May 4, 2023

Search for Gradle Enterprise agent errors and show a warning if errors are detected:

Screenshot 2023-05-06 at 14 44 23

The feature requires an explicit opt-in from the user:

Screenshot 2023-05-06 at 14 55 53

TODO:

  • update README - not needed, since this functionality is not yet available for the user
  • test with new agents when released

@c00ler c00ler self-assigned this May 4, 2023
@c00ler c00ler added the feature label May 5, 2023
@c00ler c00ler requested review from alextu and welandaz May 6, 2023 12:57
@c00ler c00ler marked this pull request as ready for review May 11, 2023 15:04
Copy link
Member

@welandaz welandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Left some small comments

@c00ler
Copy link
Contributor Author

c00ler commented May 12, 2023

@welandaz @alextu For now I've removed the toggle from the UI: 7a8f660 The feature will not be available for the users.

@c00ler c00ler requested a review from welandaz May 12, 2023 09:53
c00ler added 2 commits May 15, 2023 09:27
* master:
  Use EnvironmentContributingAction to toggle auto-injection (#296)
  Bump com.gradle.enterprise from 3.13 to 3.13.1 (#295)
  Revert "Add Gradle Enterprise exceptions log filter"
  Add Gradle Enterprise exceptions log filter

# Conflicts:
#	src/test/groovy/hudson/plugins/gradle/injection/BuildScanInjectionMavenIntegrationTest.groovy
@c00ler c00ler merged commit 9ea2575 into master May 15, 2023
@c00ler c00ler deleted the avenderov/ge-errors-filter branch May 15, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants