Use Chrome for testing #369
Conversation
And do not run acceptance tests on jenkins.io where neither firefox, chrome, firefox-container and chrome-container are currently working for us.
|
|
||
| private WebDriver createChromeWebDriver() { | ||
| ChromeOptions chromeOptions = new ChromeOptions(); | ||
| chromeOptions.setBinary("/usr/bin/google-chrome-for-testing"); |
There was a problem hiding this comment.
Using /usr/bin/google-chrome-for-testing would point you to the latest version and as soon as we would update this would conflict with your chromedriver version.
I would change this to: /opt/google/119.0.6045.105/chrome-linux64/chrome
zielezin@dev34:~$ /opt/google/119.0.6045.105/chrome-linux64/chrome --version
Google Chrome for Testing 119.0.6045.105
There was a problem hiding this comment.
So actually, after investigating, it turned out we can delegate all the driver plumbing to Selenium. It will try to find the specified Chrome version installed and if not found, download it. So my latest commit specifies the version to stable which should afaik try to find a stable Chrome installed, and if not present will download the latest stable.
| @@ -5,7 +5,6 @@ import java.net.URL | |||
|
|
|||
| plugins { | |||
| java | |||
| id("buildlogic.chromedriver") | |||
There was a problem hiding this comment.
As Selenium does this I think this plugin can be deleted too.,
There was a problem hiding this comment.
In particular because of ATH doesn't work on recent Firefox acceptance-test-harness#1170 on firefox-container, but we still have failing acceptance tests on jenkins.io with chrome-container, that do not happen locally or on other infra.
Testing done
Ran build on jenkins.io and internally.
Submitter checklist