Apply Develocity Maven extension only if not already applied #393
Conversation
| } | ||
|
|
||
| static MavenExtensions fromFilePath(FilePath extensionsFile) { | ||
| try(InputStream inputStream = extensionsFile.read()) { |
There was a problem hiding this comment.
Closing the InputStream here as it's not clear whether DocumentBuilder.parse() will do it
| private static boolean mavenExtensionAlreadyApplied(InjectionConfig config, FilePath workspace) throws IOException, InterruptedException { | ||
| if (!config.isInjectMavenExtension()) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
If injection of Maven extension is tuned off, we don't need to perform this check and simply leave things as they are
There was a problem hiding this comment.
Good job!
Some notes:
- I've tested it manually with a docker agent, works fine for both freestyle and pipeline
- This is kind of breaking change, ie if users had the injection configured on projects, it won't publish anymore to the globally configured DV server. I assume it's ok if it's properly communicated in release notes?
|
|
||
| String expr = String.format(EXTENSION_XPATH_EXPR, coordinates.groupId(), coordinates.artifactId()); | ||
| try { | ||
| XPathExpression exprCompiled = XPATH.compile(expr); |
There was a problem hiding this comment.
I thought we would pay a small price to compile it every time, but it looks like they already have some internal optimization: first compile call takes about ~6ms, next one 0ms
There was a problem hiding this comment.
The method expects any Maven Coordinates, so we can test it easily.
I think it's ok for our use case
Right, that would be the case for Maven ones. The "enforce url" feature only works when using Gradle plugin from what I can see, so there would be no way to override it for Maven extension use case. We can introduce it though in a separate PR, probably makes sense even for the next release to mitigate this somehow |
That's a good point, I think it makes sense to release both, so when the enforce url is true, the extension is taken from the project but the URL is overridden. |
If a project already has Develocity Maven extension applied, we shouldn't override it with our injection.
If Develocity Maven extension injection is enabled, we will check the
.mvn/extensions.xmlafter checkout for the presence of said extension and disable the injection.