Rename tokenExpiry field to prevent Folder corruption issues when upgrading from old versions of this plugin #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…grading from old versions of this plugin
jglick
approved these changes
Aug 23, 2024
bluesliverx
reviewed
Aug 24, 2024
.../java/com/datapipe/jenkins/vault/credentials/AbstractVaultTokenCredentialWithExpiration.java
Outdated
Show resolved
Hide resolved
bluesliverx
approved these changes
Aug 27, 2024
|
I'm not sure who has merge permissions here, but I do not. |
Artmorse
approved these changes
Aug 27, 2024
jeromepochat
approved these changes
Aug 27, 2024
|
@jetersen Any chance you can help get this released? |
jetersen
approved these changes
Aug 30, 2024
dwnusbaum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XStream attempts to deserialize all fields in XML files that have a corresponding field in the class, even if it is marked
transient. This means that #325 did not actually fix the issues described in #323, #324, and #326, which were caused by #223.This should fix #323, #324, and #326. I tested it manually with a corrupted folder.
Testing done
Submitter checklist