Serialize access to HetznerCloudResourceManager#createServer() #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in #57, there is small window of oportunity for race condition during server creation. Primary IP allocation and server creation are two separate API calls that can't be done atomically. By serializing access to this method, this could be further mitigated as HetznerCloud instance is using same instance of HetznerCloudResourceManager during its lifecycle. This fix won't prevent problems done externally. Closes #57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #57, there is small window of opportunity for race condition during server creation. Primary IP allocation and server creation are two separate API calls that can't be done atomically. By serializing access to this method, this could be further mitigated as
HetznerCloudinstance is using same instance ofHetznerCloudResourceManagerduring its lifecycle.This fix won't prevent problems done externally.
Closes #57