Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that cloud name is valid label value. #76

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Validate that cloud name is valid label value. #76

merged 1 commit into from
Sep 26, 2023

Conversation

rkosegi
Copy link
Contributor

@rkosegi rkosegi commented Sep 26, 2023

Currently there is no validation for cloud name,
but its value is being used in label expression while talking to Hetzner cloud API.

Add validation to config page and enhance documentation, so it's clear what is expected there.

Fixes: #75

Currently there is no validation for cloud name,
but its value is being used in label expression while talking
to Hetzner cloud API.

Add validation to config page and enhance documentation,
so it's clear what is expected there.

Fixes: #75

Signed-off-by: Richard Kosegi <richard.kosegi@gmail.com>
@rkosegi rkosegi added documentation Improvements or additions to documentation bug Something isn't working labels Sep 26, 2023
@rkosegi rkosegi merged commit 8acf551 into main Sep 26, 2023
12 checks passed
@rkosegi rkosegi deleted the bugs/75 branch September 26, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hetzner API complains about "invalid label_selector: expected comma at pos 75"
1 participant