Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify logging with Java 11 StandardCharsets.UTF_8 #142

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Simplify logging with Java 11 StandardCharsets.UTF_8 #142

merged 1 commit into from
Apr 15, 2023

Conversation

iqbalrohail
Copy link
Contributor

changed StandardCharsets.UTF_8.name() to StandardCharsets.UTF_8 in PrintStream logger() method and remove unnecessary exception check .
Improvement for PR #140

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did

@iqbalrohail iqbalrohail requested a review from a team as a code owner April 15, 2023 10:17
@iqbalrohail iqbalrohail mentioned this pull request Apr 15, 2023
Closed
3 tasks
@iqbalrohail iqbalrohail changed the title improved PrintStream logger() method by changing StandardCharsets.UTF_8.name() to StandardCharsets.UTF_8 improved PrintStream logger() method by changing StandardCharsets.UTF_8.name() to StandardCharsets.UTF_8 version_1 Apr 15, 2023
@MarkEWaite MarkEWaite changed the title improved PrintStream logger() method by changing StandardCharsets.UTF_8.name() to StandardCharsets.UTF_8 version_1 Use StandardCharsets.UTF_8 to simplify logging Apr 15, 2023
@MarkEWaite MarkEWaite added the chore Maintenance label Apr 15, 2023
MarkEWaite
MarkEWaite approved these changes Apr 15, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite changed the title Use StandardCharsets.UTF_8 to simplify logging Simplify logging with Java 11 StandardCharsets.UTF_8 Apr 15, 2023
@MarkEWaite MarkEWaite merged commit 5f34a0f into jenkinsci:master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
chore Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iqbalrohail @MarkEWaite