Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump io.jenkins.tools.bom:bom-2.440.x from 3208.vb_21177d4b_cd9 to 3413.v0d896b_76a_30d #179

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Bump io.jenkins.tools.bom:bom-2.440.x from 3208.vb_21177d4b_cd9 to 3413.v0d896b_76a_30d #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4aa9b8b
Bump io.jenkins.tools.bom:bom-2.440.x
dependabot[bot] Oct 1, 2024
c75046c
Adapt tests to handle FormException
MarkEWaite Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ THE SOFTWARE.
<dependency>
<groupId>io.jenkins.tools.bom</groupId>
<artifactId>bom-${jenkins.baseline}.x</artifactId>
<version>3208.vb_21177d4b_cd9</version>
<version>3413.v0d896b_76a_30d</version>
<scope>import</scope>
<type>pom</type>
</dependency>
Expand Down
3 changes: 2 additions & 1 deletion src/test/java/jenkins/plugins/http_request/HttpRequestStepCredentialsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import com.cloudbees.plugins.credentials.domains.Domain;
import com.cloudbees.plugins.credentials.impl.CertificateCredentialsImpl;
import com.cloudbees.plugins.credentials.impl.UsernamePasswordCredentialsImpl;
import hudson.model.Descriptor.FormException;
import hudson.model.Fingerprint;
import hudson.model.Result;

Expand Down Expand Up @@ -55,7 +56,7 @@ String getLogAsStringPlaintext(WorkflowRun f) throws java.io.IOException {
private File p12simple;
private File p12trusted;

private StandardCredentials getInvalidCredential() {
private StandardCredentials getInvalidCredential() throws FormException {
String username = "bad-user";
String password = "bad-password";
CredentialsScope scope = CredentialsScope.GLOBAL;
Expand Down
3 changes: 2 additions & 1 deletion src/test/java/jenkins/plugins/http_request/HttpRequestTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import org.junit.Rule;
import org.jvnet.hudson.test.JenkinsRule;

import hudson.model.Descriptor.FormException;
import com.cloudbees.plugins.credentials.Credentials;
import com.cloudbees.plugins.credentials.CredentialsScope;
import com.cloudbees.plugins.credentials.SystemCredentialsProvider;
Expand All @@ -56,7 +57,7 @@ final String baseURL() {
return SERVER.baseURL;
}

void registerBasicCredential(String id, String username, String password) {
void registerBasicCredential(String id, String username, String password) throws FormException {
credentials.get(Domain.global()).add(
new UsernamePasswordCredentialsImpl(CredentialsScope.GLOBAL,
id, "", username, password));
Expand Down