Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of HTTP Request headers #6

Merged
merged 8 commits into from
Mar 14, 2015
Merged

Addition of HTTP Request headers #6

merged 8 commits into from
Mar 14, 2015

Conversation

James-Chapman
Copy link
Contributor

I've added "Accept: foo", "Content-type: bar" and a custom header field.

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

ndeloof
ndeloof reviewed Feb 23, 2015
View reviewed changes
src/main/java/jenkins/plugins/http_request/HttpRequest.java
return "text/html";
}
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make this part of MimeType enum as an attribute ?

@ndeloof
Copy link

ndeloof commented Feb 25, 2015

LGTM

@James-Chapman
Copy link
Contributor Author

Only just seen I can add comments here. (I'm still new to GitHub)
FYI - That last commit message is completely incorrect. Apologies for any confusion it may cause.

@daniel-beck
Copy link
Member

Change commit message using git commit --amend; replace latest commit (after making sure no further undesired changes snuck in) using git push -f. (If there are no users who've cloned your repo of course.)

@James-Chapman
Copy link
Contributor Author

Thanks Daniel.
Commit message amended and re-pushed.

@janario janario self-assigned this Mar 13, 2015
janario added a commit that referenced this pull request Mar 14, 2015
@janario
Merge pull request #6 from James-Chapman/master
aa3d97e 
Sorry for the time. I've been a lot busy in the past months

Thanks for the pull request.

I'm going to see some backward compatibility and release it soon.
@janario janario merged commit aa3d97e into jenkinsci:master Mar 14, 2015
@janario
Copy link
Member

janario commented Mar 14, 2015

Sorry for the time. I've been lot busy in the past months

Thanks for the pull request.

I'm going to see some backward compatibility and release it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@janario janario

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@James-Chapman @jenkinsadmin @ndeloof @daniel-beck @janario