Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URL details as part of the exception #74

Merged

Conversation

jsearby
Copy link
Contributor

@jsearby jsearby commented Aug 27, 2021

Adding target URL within the exception message to improve plugin operability.
https://issues.jenkins.io/browse/JENKINS-66469

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Can you please update the tests to assert that the output is as expected in both the success and failure case, as in #72?

@MarkEWaite MarkEWaite requested a review from a team as a code owner October 15, 2022 23:22
@MarkEWaite MarkEWaite merged commit bcd8751 into jenkinsci:master Feb 4, 2023
MarkEWaite added a commit to MarkEWaite/repository-permissions-updater that referenced this pull request Jun 22, 2023
The http-request plugin needs a new release to deliver the features
and bug fixes that have accumulated since its last release in Aug 2022.
Some of those new features and bug fixes include:

* Require Jenkins 2.361.4 as minimum Jenkins version
  (jenkinsci/http-request-plugin#128)
* JENKINS-69081 - Track credential usage
  (jenkinsci/http-request-plugin#113)
* JENKINS-69155 - Snapshot authentication credentials
  (jenkinsci/http-request-plugin#111)
* Upgrade HtmlUnit from 2.x to 3.x
  (jenkinsci/http-request-plugin#148)

Documentation improvements include:

* Improve feature descriptions in documentation
  (jenkinsci/http-request-plugin#141)
* Add URL details as part of the exception
  (jenkinsci/http-request-plugin#74)
* Add a response header example to documentation
  (jenkinsci/http-request-plugin#133)
* rewording of abstract section
  (jenkinsci/http-request-plugin#130)
* Drop redundant part of example
  (jenkinsci/http-request-plugin#122)

Maintenance improvements include:

* Remove divBasedFormLayout from jelly files
  (jenkinsci/http-request-plugin#149)

jenkinsci/http-request-plugin#150 is the pull
request that prompted this adoption request

Reverts part of pull request:

* jenkins-infra#2950
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants