-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent [ab][0-9]
in commit hashes from being treated as alpha
or beta
#24
Conversation
...ion/src/test/java/io/jenkins/tools/incrementals/git_changelist_maven_extension/MainTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine workaround :)
Released as 1.3. Ought to start showing up in Dependabot soon. |
Thanks for this improvement. I think there may be a further change needed in order to allow ci.jenkins.io to publish incrementals. The tip of the master branch of the git client plugin has changes that I wanted to test in my development environment. The build is successful, but incrementals were not published, even though it is the tip of the master branch. The message in the log says:
I think that the issue is related to the use of My workaround was simple. I downloaded the git-client.hpi file from the Jenkins job and stored it in my dev repository. However, I suspect most people don't store plugin binaries in their source repositories. I do that because I need some reason to test Git LFS. Submitted as issue #25 |
Builds are failing all over the place on infra.ci.jenkins.io atm with
so the automated PRs haven't been triggered for updating this |
The release reports generated by sites like https://mvrepository.com seem to apply the same version number parsing rules as Apache Maven. That causes those sites to see version numbers that contain the letter 'a' or the letter 'b' followed by an alphanumeric character as a designator for an alpha or a beta release. See jenkinsci/incrementals-tools#24 for the rationale for that specific change and https://github.com/jenkinsci/bom#readme for the details of the bom and https://github.com/jenkinsci/jep/blob/master/jep/229/README.adoc for the version number details.
https://github.com/jenkinsci/plugin-compat-tester/blob/5a86f00cbbbba4e2c7dcb63f75538c8765e24e96/plugins-compat-tester/src/main/java/org/jenkins/tools/test/PluginCompatTester.java#L126-L127 needs to be adjusted as well in order for recent core incrementals to work with PCT (cf #28). |
|
Causes problems with
|
Yes, this is tracked in #27 and revapi/revapi#263. The fix is already committed but not yet released. |
Fixes jenkins-infra/jenkins.io#4783 by converting (e.g.)
852b473a2b8c
which parses as852-beta-473-alpha-2-beta-8-c
to852b_473a_2b_8c
which parses as852-b_-473-a_-2-b_-8-c
. A bit ugly but I did not see a better approach. Tried just capitalizing the hash, but this does not work—the comparisons are apparently case-insensitive.Could probably be more conservative and only replace
[ab]
when these are not surrounded by other letters ([a-f]
); not sure if anyone cares.As in jenkins-infra/incrementals-publisher#14, at least https://github.com/jenkins-infra/incrementals-publisher/blob/00be8881121de3bb26ba91605aafedeecbba7435/lib/pipeline.js#L70 would likely need to be amended as well for JEP-305 deployments (should be irrelevant for JEP-229).