Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed 1 unnecessary stubbing in CommentCommandTest.java #198

Merged

Conversation

ARUS2023
Copy link
Contributor

@ARUS2023 ARUS2023 commented Oct 5, 2023

Testing done

Submitter checklist

In our analysis of the project, we observed that 1) the test CommentCommandTest.testUnknownBuildNumber contains 1 unnecessary stubbing.

Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html).

We propose below a solution to remove the unnecessary stubbing.

@ARUS2023 ARUS2023 requested a review from a team as a code owner October 5, 2023 16:22
@jimklimov jimklimov merged commit 89448bd into jenkinsci:master Oct 9, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants