Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMConnectionProvider.java: getAuthenticationHolder(): fix check for Bot user name… #211

Merged
merged 4 commits into from
Jan 23, 2024

Commits on Jan 22, 2024

  1. IMConnectionProvider.java: getAuthenticationHolder(): fix check for B…

    …ot user name, to exempt empty strings (lack of specific configuration) [JENKINS-72590]
    
    Signed-off-by: Jim Klimov <jimklimov+jenkinsci@gmail.com>
    jimklimov committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    6017646 View commit details
    Browse the repository at this point in the history
  2. IMConnectionProvider.java: getAuthenticationHolder(): fix check for B…

    …ot user name, to exempt empty strings (lack of specific configuration) if Jenkins security setting allows that [JENKINS-72590]
    
    Signed-off-by: Jim Klimov <jimklimov+jenkinsci@gmail.com>
    jimklimov committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    20f7802 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. IMConnectionProvider: getAuthenticationHolder(): rebalance to only th…

    …row UsernameNotFoundException when we fail to impersonate() or to User.get() AND the name is blank [JENKINS-72590]
    
    This allows e.g. IRC Bot to start and send messages ("are you talking to
    me?" and build notifications) but not send commands when no Jenkins user
    is attached to the IRC configuration.
    
    Signed-off-by: Jim Klimov <jimklimov+jenkinsci@gmail.com>
    jimklimov committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    ce1bbe9 View commit details
    Browse the repository at this point in the history
  2. Bot.java: onMessage(): if we have a UsernameNotFoundException blockin…

    …g command execution, outline this to private message sender [JENKINS-72590]
    
    Signed-off-by: Jim Klimov <jimklimov+jenkinsci@gmail.com>
    jimklimov committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    438d0ca View commit details
    Browse the repository at this point in the history