Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pom.xml: make Maven integration plugin optional #231

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

hashar
Copy link
Contributor

@hashar hashar commented Oct 23, 2024

maven-plugin has been added as a dependency with 30ca891 along with jenkins-war 2.3 and jenkins-core 2.3 and I guess it was no more bundled in Jenkins as a result.

The only usage is in hudson.plugins.im.bot.HealthCommandTest, otherwhise instant messaging does not depend on the plugin, it merely supports it.

Make the Maven plugin optional, this allows administrators to remove the plugin when it is otherwise not used.

Note: given the Maven plugin is only needed for testing the integration, my guess is that it should also be marked with <scope>test</scope>?

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

maven-plugin has been added as a dependency with 30ca891 along with
jenkins-war 2.3 and jenkins-core 2.3 and I guess it was no more bundled
in Jenkins as a result.

The only usage is in hudson.plugins.im.bot.HealthCommandTest, otherwhise
instant messaging does not depend on the plugin, it merely supports it.

Make the Maven plugin optional, this allows administrators to remove the
plugin when it is otherwise not used.
@hashar hashar requested a review from a team as a code owner October 23, 2024 13:24
@jimklimov jimklimov merged commit 5308d7d into jenkinsci:master Nov 5, 2024
17 checks passed
@hashar hashar deleted the optional-maven-plugin branch November 5, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants