do not bundle a library whose classes are already provideded by core #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the activation framework classes are already provided by core. Prior to jenkins-2.235 they where patched 1.1.1 versions but since jenkinsci/jenkins@abb1310 it is the 1.2.1 version transitively from jakarta.mail As the plugin is neither using plugin first classloader nor the mask-classes approach this is just bloat - so remote it. bumps the parent version and the minimum jenkins baseline to be > 2.235 to ensure we do get at least a 1.2.x version
jtnord
commented
Oct 1, 2021
| <changelist>-SNAPSHOT</changelist> | ||
| <java.level>8</java.level> | ||
| <jenkins.version>2.222.4</jenkins.version> | ||
| <jenkins.version>2.249.1</jenkins.version> |
There was a problem hiding this comment.
jenkinsci/jenkins#4660 was in 2.235 using an LTS that is newer than that
jtnord
commented
Oct 1, 2021
timja
approved these changes
Oct 1, 2021
YOLO, so here's hoping this works with m-r-p Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
timja
approved these changes
Oct 1, 2021
car-roll
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the activation framework classes are already provided by core.
Prior to jenkins-2.235 they where patched 1.1.1 versions but since
jenkinsci/jenkins@abb1310
it is the 1.2.1 version transitively from jakarta.mail
As the plugin is neither using plugin first classloader nor the
mask-classes approach this is just bloat - so remove it.
bumps the parent version and the minimum jenkins baseline to be > 2.235
to ensure we do get at least a 1.2.x version