Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable CD for the repository #97

Merged
merged 3 commits into from
Oct 1, 2021
Merged

enable CD for the repository #97

merged 3 commits into from
Oct 1, 2021

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Oct 1, 2021

see also jenkins-infra/repository-permissions-updater#2106

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jtnord jtnord requested a review from a team October 1, 2021 20:04
timja
timja reviewed Oct 1, 2021
View reviewed changes
pom.xml Show resolved Hide resolved
@jtnord
tweak the version and add missing property
4af2a67 
@timja pointed out that a few things where not quite as documented.

Better to stay on the happy path :)
@jtnord jtnord requested a review from timja October 1, 2021 20:17
timja
timja reviewed Oct 1, 2021
View reviewed changes
.github/workflows/cd.yaml Outdated Show resolved Hide resolved
@jtnord @timja
Update .github/workflows/cd.yaml
ae44193 
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
jglick
jglick approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right.

@jtnord jtnord mentioned this pull request Oct 1, 2021
Closed
@jtnord jtnord added the chore label Oct 1, 2021
@jtnord jtnord merged commit 9173dd3 into jenkinsci:master Oct 1, 2021
@jtnord jtnord deleted the enable-cd branch October 1, 2021 21:01
@jglick
Copy link
Member

jglick commented Oct 4, 2021

https://github.com/jenkinsci/jackson2-api-plugin/releases/tag/2.13.0-226.v0c5dd2d2fd2a looks like it worked.

@timja
Copy link
Member

timja commented Oct 4, 2021

Dependabot doesn't seem interested in it for bom

I wonder if it can't handle the version format change

@jtnord
Copy link
Member Author

jtnord commented Oct 4, 2021

https://github.com/jenkinsci/jackson2-api-plugin/releases/tag/2.13.0-226.v0c5dd2d2fd2a looks like it worked.

dependabot also needed https://github.com/jenkinsci/jackson2-api-plugin/pull/99/files

@jglick jglick mentioned this pull request Oct 4, 2021
Merged
6 tasks
@jglick
Copy link
Member

jglick commented Oct 4, 2021

I wonder if it can't handle the version format change

Not sure. 2.13.0-226.v0c5dd2d2fd2a seems clearly newer than 2.12.4-1?

@timja
Copy link
Member

timja commented Oct 4, 2021

@jtnord I meant dependabot users consuming this repo, it’s currently refusing to update the bom no matter how much I poke it

I’ve created a PR to update to this version to see if it fixes the next one jenkinsci/bom#669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

@timja timja timja approved these changes

@car-roll car-roll car-roll approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jtnord @jglick @timja @car-roll