Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an icon for javadocs #41

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

NotMyFault
Copy link
Member

Previously, the plugin used the default help icon, but it doesn't look well in a list view. I replaced it with a Duke sprite. Additionally I added an index.jelly to provide a bit of information in the plugin manager.

@oleg-nenashev (if you're (still) the project maintainer 👀)

Before After
  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Also add index.jelly with with a few information for the plugin manager
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very good question whether I am a project maintainer. I'm listed as one though, and the pull request looks good to me

@oleg-nenashev oleg-nenashev merged commit 626a7dc into jenkinsci:master Nov 1, 2021
@NotMyFault NotMyFault deleted the style/master/add-icon branch November 1, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants