Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CD #48

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Enable CD #48

merged 2 commits into from
Feb 8, 2022

Conversation

batmat
Copy link
Member

@batmat batmat commented Feb 8, 2022

@batmat batmat requested review from jglick and timja February 8, 2022 08:58
pom.xml Outdated Show resolved Hide resolved
timja
timja previously approved these changes Feb 8, 2022
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm apart from duplicated property

Thanks Tim

Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
@batmat batmat enabled auto-merge February 8, 2022 09:50
@batmat batmat merged commit 905b862 into jenkinsci:master Feb 8, 2022
@batmat batmat deleted the enable-cd branch February 8, 2022 10:05
@jglick
Copy link
Member

jglick commented Feb 8, 2022

Again remember that the latest release contains uncategorized changes, though since there was already https://github.com/jenkinsci/javadoc-plugin/releases/tag/javadoc-1.6 it is likely that all of these at least were supposed to be here. This was missing a label, and I guess #42 was using an unrecognized label maintenance which ought to be deleted.

@olamy
Copy link
Member

olamy commented Feb 9, 2022

PR here jenkinsci/.github#67

sounds logical to have entries with label maintenance going to section with title Maintenance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants