Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump parent pom - fix PCT issue in bom #12

Merged
merged 2 commits into from
Apr 13, 2020

Conversation

timja
Copy link
Member

@timja timja commented Apr 12, 2020

Fixes issue in jenkinsci/bom#214

This picks up a new version of htmlunit which allows tests to pass on newer Jenkins

@oleg-nenashev

@oleg-nenashev
Copy link
Member

Will it need a release? If we have a choice, we should rather get rid of this plugin in BOM. It would require all other plugin to go beyond 2.118 to prevent an implied dependency

@timja
Copy link
Member Author

timja commented Apr 12, 2020

Will it need a release? If we have a choice, we should rather get rid of this plugin in BOM. It would require all other plugin to go beyond 2.118 to prevent an implied dependency

I've ignored the test in bom, so up to you, I was surprised to see this plugin in bom but I assume it's due to either bundling or some plugin depending on it

The JCasC nightmare with the test harness issue was different as it stopped all tests failing because the maven build failed to run, so releases were required in all plugins

pom.xml Outdated Show resolved Hide resolved
@oleg-nenashev oleg-nenashev merged commit 8bea31c into jenkinsci:master Apr 13, 2020
@oleg-nenashev
Copy link
Member

No release ETA. Ping me here if a release is needed

@jglick
Copy link
Member

jglick commented Apr 13, 2020

IIUC we do need a release, in order to fix stuff in bom.

@timja
Copy link
Member Author

timja commented Apr 13, 2020

The test is currently ignored in bom, so not blocking unless we want to in ignore it?

@jglick
Copy link
Member

jglick commented Apr 13, 2020

Well, yes, but we would like to remove test skips as quickly as we can. Not immediately blocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants