Add Configuration as Code test + update to Jenkins 2.222.1 as a minimum requirement #13
Conversation
|
I'm listed as maintainer: https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/plugin-jdk-tool.yml but I have no rights in this repo. Could any maintainer give me access please? @aheritier @oleg-nenashev @jglick @dwnusbaum |
|
@MRamonLeon you should be added in teams/jdk-tool-plugin-developers |
oleg-nenashev
changed the title
There was a problem hiding this comment.
Please use the Jenkins core version aligned with minimum version supported in https://github.com/jenkinsci/bom . Otherwise it will be harder to pick-up the new plugin's release in Plugin BOM
There was a problem hiding this comment.
Sorry if my comment was not clear enough. I meant the minimum supported Jenkins version. Currently it is 2.176 in BOM: https://github.com/jenkinsci/bom/tree/master/bom-2.176.x
|
I used this one because it's the one we've used for other CasC plugins, but the test works, so I guess we can use this lower version. Pinging @alecharp just in case I miss something regarding a required minimum version for CasC. |
|
You can go back to 2.222.x as far as I am concerned. There is no difficulty handling plugins with baselines newer than the minimum currently supported by the BOM. It just means subsequent updates are not applied to the older lines. |
| <relativePath /> | ||
| </parent> | ||
| <artifactId>jdk-tool</artifactId> | ||
| <version>1.5-SNAPSHOT</version> | ||
| <packaging>hpi</packaging> | ||
| <properties> | ||
| <jenkins.version>2.112</jenkins.version> | ||
| <jenkins.version>2.176.1</jenkins.version> |
There was a problem hiding this comment.
or
| <jenkins.version>2.176.1</jenkins.version> | |
| <jenkins.version>2.222.3</jenkins.version> |
| <dependencies> | ||
| <dependency> | ||
| <groupId>io.jenkins.tools.bom</groupId> | ||
| <artifactId>bom-2.176.x</artifactId> |
There was a problem hiding this comment.
if so,
| <artifactId>bom-2.176.x</artifactId> | |
| <artifactId>bom-2.222.x</artifactId> |
to match
pom.xml
Outdated
| @@ -4,14 +4,14 @@ | |||
| <parent> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>plugin</artifactId> | |||
| <version>3.57</version> | |||
| <version>4.2</version> | |||
There was a problem hiding this comment.
| <version>4.2</version> | |
| <version>4.3</version> |
Add Configuration as Code (CasC) test to certify the plugin works well with CasC
@varyvol @alecharp @rsandell