Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the tar extraction of a JDK less verbose #3

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

JasonMathison
Copy link
Contributor

Currently we have to scroll through many pages of JDK installation tar output at the beginning on our job's console output. Specifically, jdk1.8.0_131 includes 1830 files that get traced out. The easiest solution seems to be to eliminate the verbose "v" option.

Currently we have to scroll through many pages of JDK installation tar output at the beginning on our job's console output.  Specifically, jdk1.8.0_131 includes 1830 files that get traced out.  The easiest solution seems to be to eliminate the verbose "v" option.
@dwnusbaum
Copy link
Member

@JasonMathison Sorry I just noticed this, I did not have notifications turned on for the repo. The change seems ok to me, although I don't know if there was a reason that the v flag was used in the past. (Maybe to help diagnose issues with slow unarchiving where it looked like a job was hanging?)

Also just a heads up, I would highly encourage you to not use this installation option for the JDK tool in the first place. It is unreliable and can break at any time, and with the changes to Oracle's JDK licensing with JDK 11 we need to switch to use OpenJDK downloads, which will mean that Java 8 will no longer be available from this tool. It is generally better to install the JDK on your build agents in advance instead of installing it on-demand using Jenkins. If you really need to install it on-demand, then it is better to use something like the "Run a shell command installer" with a script that runs apt-get install openjdk-8-jdk or similar.

Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that flag has been there since that code was initially added (jenkinsci/jenkins@219a4c5), so I would be surprised if removing it upset anyone.

@theobolo
Copy link

theobolo commented Dec 4, 2018

Is possible to merge this @dwnusbaum ? :)

@dwnusbaum
Copy link
Member

Sure, I will merge and try to release sometime this week. FWIW in regards to your earlier JDK 10 comments, the issue and related ones have been reported and discussed in JENKINS-54522 and JENKINS-54305. I do not anticipate having time dedicated to work on those issues myself, but I am more than happy to review any PRs you submit (although I would still recommend trying to avoid this installation method as much as possible).

@dwnusbaum dwnusbaum merged commit e144d0d into jenkinsci:master Dec 4, 2018
@JasonMathison
Copy link
Contributor Author

JasonMathison commented Dec 4, 2018

Thanks for merging this in! I will pass along your suggestions about how we should install JDKs to our devops team.

@dwnusbaum
Copy link
Member

I just released version 1.2 of the plugin with this change. It should be live on the update center in a few hours. Thanks for the PR @JasonMathison!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants