Upgrade from Commons HttpClient 3.x to HttpComponents Client 4.x

[basil]

Problem

jdk-tool, which is bundled in core, uses a patched version of the deprecated Commons HttpClient 3.x library. Using deprecated code is not sustainable and inhibits us from eventually removing this library from core in jenkinsci/jenkins#7312.

Solution

While in the long term this plugin ought to be rewritten to comply with JDK Script Friendly URLs and/or the native HTTP client in newer versions of the Java Platform, both of those are more involved changes. In the short term the most expedient solution that allows this plugin to still be bundled with Jenkins core (but without using a deprecated library) is to upgrade from Commons HttpClient 3.x to HttpComponents Client 4.x.

Testing done

With

diff --git a/src/main/java/hudson/tools/JDKInstaller.java b/src/main/java/hudson/tools/JDKInstaller.java
index 07e2a3d..7abbf15 100644
--- a/src/main/java/hudson/tools/JDKInstaller.java
+++ b/src/main/java/hudson/tools/JDKInstaller.java
@@ -480,7 +480,7 @@ public class JDKInstaller extends ToolInstaller {
 
         int authCount=0, totalPageCount=0;  // counters for avoiding infinite loop
 
-        HttpRequestBase m = new HttpGet(primary.filepath);
+        HttpRequestBase m = new HttpGet("https://download.oracle.com/java/17/archive/jdk-17_linux-x64_bin.tar.gz");
 
         BasicClientCookie cookie = new BasicClientCookie("gpw_e24", ".");
         cookie.setDomain(".oracle.com");

I exercised all the changed lines (including proxy authentication) in a Pipeline job in the debugger except for the if (m.getURI().getHost().equals("login.oracle.com")) code path (lines 516-579) which I could not test because I do not have an Oracle support contract. I doubt that code path still works anyway. If it actually was working before and happens to regress, and if some user with an Oracle support contract actually cares about this, I would encourage them to debug it using their Oracle account and submit a pull request.

CC @jglick

[jglick]

Looks fine. Do we still somehow advertise even the existence of this plugin somehow?

[basil]

Not that I know of, but there are a large number of existing installations (hopefully unused!).