Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing jenkins-infra/pipeline-library#705 #98

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Testing jenkins-infra/pipeline-library#705 #98

merged 2 commits into from
Jul 27, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Jul 27, 2023

Checking jenkins-infra/pipeline-library#705. Need to verify

at which point

  • this can be reverted to clean up: d0fbea8

@jglick jglick requested a review from timja July 27, 2023 15:08
@jglick jglick requested a review from a team as a code owner July 27, 2023 15:08
@jglick
Copy link
Member Author

jglick commented Jul 27, 2023

Hmm, Incrementals deployment here happened before the build finished? How?

@jglick
Copy link
Member Author

jglick commented Jul 27, 2023

If you file a PR from an origin branch, Jenkins may temporarily create a non-PR build. Soon the branch project will be marked dead, but it seems ci.jenkins.io is not configured to immediately abort the running builds, which is an option. So jenkins-infra/pipeline-library#705 should help with that too—the branch build may run to completion, but will not deploy. Cannot test that with this PR since the branch project is already dead and not running any new builds.

@jglick jglick merged commit 0bd29ae into master Jul 27, 2023
13 checks passed
@jglick jglick deleted the jglick-patch-1 branch July 27, 2023 15:19
jglick added a commit that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants