Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiet period always getting overwritten to index < 5 ? 0 : 2 * 60 everytime a job/pipeline is edited and saved #212

Closed
kannanprasanna opened this issue Oct 2, 2020 · 11 comments

Comments

@kannanprasanna
Copy link

There have been some many issues reported earlier and PRs submitted related to this already. But all we need is to remove the default section (default="index < 5 ? 0 : 2 * 60") out of https://github.com/jenkinsci/tikal-multijob-plugin/blob/dc55c20dc01fb435d269c37319e99b21318f9f50/src/main/resources/com/tikal/jenkins/plugins/multijob/MultiJobBuilder/config.jelly#L89 . Currently, we couldn't set this to 0 or any other value since it gets overwritten again with default value when any job is edited. Could this be fixed and released soon, please?

@wdougoveto
Copy link

I have confirmed this issue as well. +1

@yorammi
Copy link
Contributor

yorammi commented Oct 3, 2020

@kannanprasanna @wdougoveto @cloudyster - is this can be fixed by PR #201 that fixes issue #200? If so, please close this as a duplicate of #200, and I'll merge the PR and soon will release a new version

@cloudyster
Copy link

PR #201 fixes this issue as well as #200; additionally it avoids quiet time calculation for disabled jobs

@kannanprasanna
Copy link
Author

I agree with @cloudyster. I'll close this issue now @yorammi . Eagerly awaiting the next release!

@wdougoveto
Copy link

@yorammi, thank you for getting version 1.34 merged and tagged. Do you know when will this start to show up as a new version in the jenkins plugins?

@yorammi
Copy link
Contributor

yorammi commented Oct 19, 2020 via email

@wdougoveto
Copy link

Thank you!

@turnopil
Copy link

Any updates so far? I can't see new release

@kannanprasanna
Copy link
Author

@yorammi , could you please let us know when the next versions could be released?

@wdougoveto
Copy link

@yorammi, also wondering when the next version will be available?

@kannanprasanna
Copy link
Author

@yorammi , thanks for getting version 1.36 published. It works fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants