[JENKINS-58771] Warn if ChannelShutdownListener loaded outside of a test context #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
approved these changes
Jan 17, 2020
varyvol
approved these changes
Jan 20, 2020
oleg-nenashev
approved these changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has happened multiple times especially prior to jenkinsci/maven-hpi-plugin#140 that
ChannelShutdownListeneris found in customer heap dumps, apparently due to mispackaged plugins. This can lead to memory leaks as everyChannelever created (and all of itsExportTables etc.) gets held onto.This should warn about it, and make it clear where the culprit is, such as
/var/lib/jenkins/plugins/xray-for-jira-connector/WEB-INF/lib/jenkins-test-harness-2.13.jarfrom XRAYJENKINS-55.