Make this compile again with a Jenkins 2.61+ dependency #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slonopotamus
approved these changes
Apr 4, 2020
|
I came up with exactly the same changes locally. |
oleg-nenashev
changed the title
JenkinsRune#buildAndAssertSuccess() and JenkinsRune#buildAndAssertStatus() work with Jenkins 2.61+
|
@oleg-nenashev It's a compile error, I doubt it's a problem at run time or we'd have noticed. |
oleg-nenashev
approved these changes
Apr 4, 2020
daniel-beck
changed the title
JenkinsRune#buildAndAssertSuccess() and JenkinsRune#buildAndAssertStatus() work with Jenkins 2.61+
|
Changing misleading title to a better one. This might not make sense standalone, but might be useful to keep around if #133 doesn't get merged soon. |
jglick
approved these changes
Apr 15, 2020
timja
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like jenkinsci/jenkins#2864 and #167 don't work well together.
Untested.