-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Console Output on the build page (behind an experimental flag) #10115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I don't have pipeline graph view installed on this instance or any other console provider |
Ah great spot, hadn't considered that that prop could be null. Defaults to the DefaultConsoleProvider now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
@janfaracik Is the screenshot for the feature flags a standard Jenkins functionality? I'm aware of the flags documentation and how to set them via script console, but never saw a UI for feature flags in Jenkins. |
Heya, yeah flags are built in. If you go to your account in Jenkins you'll see an option in the side panel for them. They're per account not global. |
This PR adds the Console Output to the build page (behind an experimental flag). This reduces the amount of clicks it takes to get to the console, making it easy to see build output.
The implementation allows for console providers (such as Pipeline Graph View) to override what displays on the build page.
Why the
new-build-page.flag
flag? Modifying the build pages is pretty fiddly due to the sidebar and summary items, so I've put this behind a flag to not disrupt existing users layouts unless they explicitly want to. Keen to make more use of this flag going forward to avoid disruption/allow for more iterative work on things like this.Freestyle
Pipeline
Flag
Testing done
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge
:Maintainer checklist