Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the 'Copy' button animation #10139

Merged
merged 5 commits into from
Jan 12, 2025

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Jan 9, 2025

Small little PR to update the 'Copy' button animation. You now get a little more visual feedback that something has been copied successfully, the copy symbol now transforms into a check mark.

Before

Screen.Recording.2025-01-09.at.15.03.54.mov

After

Screen.Recording.2025-01-09.at.14.54.44.mov

In doing so the 'Copied' tooltip has been dropped, happy to hear thoughts on this, I personally found it a little janky in how it replaced the existing tooltip on click.

Testing done

  • Animation displays as expected, copying still works

Proposed changelog entries

  • Update the 'Copy' button animation

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@janfaracik janfaracik requested a review from a team January 9, 2025 14:57
@janfaracik janfaracik added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Jan 9, 2025
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally LGTM

Copy link
Contributor

@mawinter69 mawinter69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@timja
Copy link
Member

timja commented Jan 10, 2025

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 10, 2025
@krisstern krisstern merged commit d0aa978 into jenkinsci:master Jan 12, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants