Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP [JENKINS-32503] Update commons-beanutils to 1.9.3 #2588

Closed
wants to merge 1 commit into from

Conversation

KostyaSha
Copy link
Member

@KostyaSha KostyaSha commented Oct 11, 2016

Testing PR build, seems it will fail because of stapler
https://issues.jenkins-ci.org/browse/JENKINS-32503
jenkinsci/stapler#81


This change is Reviewable

@KostyaSha
Copy link
Member Author

@abayer why you aborted my PR build?

@KostyaSha
Copy link
Member Author

@kzantow what your PR status mean?

@KostyaSha KostyaSha closed this Oct 14, 2016
@KostyaSha KostyaSha reopened this Oct 14, 2016
@oleg-nenashev oleg-nenashev added the needs-more-reviews Complex change, which would benefit from more eyes label Oct 15, 2016
@oleg-nenashev
Copy link
Member

Retriggering the build.
@kzantow's status only means that his instance continues polluting the Jenkins github repo :(

@KostyaSha
Copy link
Member Author

@oleg-nenashev build is ok with new version, real changes need to be done on stapler side that has already failing test with version used in core.

@KostyaSha KostyaSha closed this Oct 31, 2016
@KostyaSha KostyaSha reopened this Oct 31, 2016
@oleg-nenashev
Copy link
Member

12:09:59 Flaked tests: 
12:09:59 jenkins.model.StartupTest.noWarnings(jenkins.model.StartupTest)
12:09:59   Run 1: StartupTest.noWarnings:45 expected:<[]> but was:<[Failed Loading plugin Maven Integration plugin v2.14 (maven-plugin)]>
12:09:59   Run 2: PASS
12:09:59 
12:09:59 

Seems we still have an issue with the master branch

This PR is unlikely related, 👍

@oleg-nenashev oleg-nenashev added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback and removed needs-more-reviews Complex change, which would benefit from more eyes labels Nov 5, 2016
@oleg-nenashev
Copy link
Member

Ready to merge since nobody votes against

@oleg-nenashev oleg-nenashev added the on-hold This pull request depends on another event/release, and it cannot be merged right now label Nov 5, 2016
@oleg-nenashev
Copy link
Member

From what I see there is no need in merge before Stapler patch gets integrated, right? CC @KostyaSha

@daniel-beck
Copy link
Member

What's the nature of Work In Progress here? Is this actually supposed to get merged?

@oleg-nenashev
Copy link
Member

Retriggering the build

@daniel-beck
Copy link
Member

AFAIR @KostyaSha explained to me this is not supposed to get merged, at least for now. Please correct me if I got this wrong.

@daniel-beck daniel-beck removed the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 16, 2016
@KostyaSha KostyaSha closed this Jul 30, 2017
@KostyaSha KostyaSha reopened this Jul 30, 2017
@KostyaSha KostyaSha closed this Jul 30, 2017
@KostyaSha KostyaSha reopened this Jul 30, 2017
@KostyaSha KostyaSha closed this Jul 30, 2017
@KostyaSha
Copy link
Member Author

KostyaSha commented Jul 30, 2017

wtf are this this PR builders?

@KostyaSha KostyaSha reopened this Jul 30, 2017
@KostyaSha KostyaSha closed this Jul 31, 2017
@KostyaSha KostyaSha reopened this Jul 31, 2017
@KostyaSha
Copy link
Member Author

@stephenc how trigger PR build?

@stephenc
Copy link
Member

@KostyaSha you just have to be patient, the rate limit means that it can take a minute or two to see the close and re-open, but it will see the close and reopen

@daniel-beck
Copy link
Member

@KostyaSha Could you please respond to my previous comments? It's unclear to me whether this is supposed to be merged ever.

@alecharp
Copy link
Member

alecharp commented Jan 28, 2019

I've been trying to upgrade the library in Jenkins today. A brilliant failure. The project, for its 2.0.0 changed its GAV and reflected the ArtifactId change to the fullclass names, moving from org.apache.commons.beanutils.* to org.apache.commons.beanutils2.*.
I'm all for not sticking to very old version, but this change in commons-beanutils project will provide us a lot of work. I stopped trying to use the new details after checkouting stapler/stapler project and it was not the end of it..

@alecharp
Copy link
Member

@KostyaSha would you like to continue investigating on this topic or should we close this PR?

@KostyaSha KostyaSha closed this Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-hold This pull request depends on another event/release, and it cannot be merged right now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants