[JENKINS-47896] SerializableOnlyOverRemoting #3980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the implementation specifics, some classes in the core are serializable only over Remoting. This change just marks these classes and utilizes the convenience method in the interface for serialization/deserialization operations.
… of github.com:oleg-nenashev/jenkins into SerializableOnlyOverRemoting-JENKINS-47896
4 tasks
batmat
approved these changes
Apr 19, 2019
jglick
added
the
ready-for-merge
|
Someone else needs to write a changelog for this. |
|
No changelog is needed here. |
oleg-nenashev
approved these changes
Apr 25, 2019
| @@ -1828,7 +1830,7 @@ void skip0() { | |||
| /** | |||
| * Represents a process tree over a channel. | |||
| */ | |||
| public static class Remote extends ProcessTree implements Serializable { | |||
| public static class Remote extends ProcessTree { | |||
There was a problem hiding this comment.
Could it be a breaking change? I know it comes from #3144 , but I am not sure why I did that
There was a problem hiding this comment.
This implements Serializable clause was always redundant, given the superclass:
public abstract class ProcessTree implements Iterable<OSProcess>, IProcessTree, SerializableThere was a problem hiding this comment.
Right. One month without coding for me :D
|
@daniel-beck added some changelog summary just in case you still expect it |
|
FYI https://issues.jenkins-ci.org/browse/JENKINS-57229 is most likely caused by this PR |
|
Also Maven Plugin and SCoverage according to https://issues.jenkins-ci.org/browse/JENKINS-57244 . So we have 4 plugins which misuse serialization The proposed plan is to...
|
This was referenced May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3144 with a merge conflict resolved and a minor fixup. See jenkinsci/remoting#206 for background.
Proposed Changelog