-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Ionicons (symbols) to <l:Icon> and <l:task> components #6186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An interesting approach to get a rid of Tango (and other) icons and switch to a contemporary solution 🎉
I'm wondering if it would be possible and actually realistic to work with overrides again like it's done for GIF -> PNG -> SVG icons provided by core.
E.g. imagine my plugin baseline is 2.289 and I reference to icon-gear icon-md
in my jelly files to access my imaginary plugin configuration. If I run on the baseline, Jenkins displays me a PNG of the icon, on a version newer than 2.308 a SVG and on 2.anyFutureRelease the ionicon. That way I can retain backwards compatibility with the third last LTS release, but still display an ionicon over a Tango SVG on an appropriate version.
Though that is only an imaginary scenario that plopped into my mind when thinking about it.
On a different note, that doesn't work out nicely with non-core icons in the management or sidebar view
core/src/main/java/jenkins/model/ModelObjectWithContextMenu.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return prependTitleIfRequired(icon, title); | ||
// for Jelly | ||
@Restricted(NoExternalUse.class) | ||
public static String getSymbol(String name, String title) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the code I'm pretty sure this won't work for plugins wanting to add their own symbol.
Probably okay for this PR but should be addressed in a follow up
@@ -2289,4 +2290,49 @@ public static boolean isContextMenuVisible(Action a) { | |||
return true; | |||
} | |||
} | |||
|
|||
public static Icon tryGetIcon(String iconGuess, JellyContext context) { | |||
if (iconGuess.startsWith("symbol-")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some code path iconGuess
can be null, either needs a null check, or callers adjusted in jelly to prevent this
Noticed on the update center page when installing plugins: http://localhost:8080/updateCenter/
The gear icon is updated |
* Optional icon XML, if set it's used instead of @icon for the menu item | ||
*/ | ||
@Exported | ||
@SuppressFBWarnings(value = "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD", justification = "read by Stapler") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the suppression now
That's a really great suggestion :) It wasn't too much work so I've added a small translation function which will existing Tango icons and translate them automatically to Jenkins Symbols, preserving styling etc. There are currently five icons supported by the translation layer although I plan to add more in a later PR so as not to balloon this one up more.
Hmm they're working on my end oddly enough What's the address you're accessing Jenkins on? I'm using Thanks for having a look through the code @timja - I've made the changes you've requested/suggested - thanks a lot :) |
Opened a PR for that: jenkins-infra/jenkins.io#4900 👍 |
@janfaracik you able to take a look at:
|
Done 👍 Added a line mentioning Symbols for Action.java, replaced the doc for Summary.jelly + removed the icon loading logic (as its now all in Icon.jelly) |
@uhafner you able to take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the documentation!
This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
"Pipeline Syntax" and "Changes" icons are missing in 2.335, I think that comes from this PR. The src of the missing images is |
icon-computer
Also /icon-computer |
We're tracking the regressions in https://issues.jenkins.io/browse/JENKINS-67832 and https://issues.jenkins.io/browse/JENKINS-67828 |
Investigating this |
finishing testing of a fix 😄 |
commit 5144035e5503591e57d27b45f4114706d96d1c7a Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Tue Mar 22 07:46:49 2022 +0000 Replace Tango icons with Jenkins Symbols (#6307) Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com> Co-authored-by: Adrien Lecharpentier <adrien.lecharpentier@gmail.com> Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com> Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com> commit afb061ed4e84f833cdc41c2b31ec848c88dbdbcb Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Mar 21 22:10:05 2022 -0700 Bump Stapler from 1666.v0275e61a_9874 to 1669.v95a_4b_919a_b_a_2 (#6393) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 101dafd69f4461023b6bb36e1315ca5b6969b54e Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Mar 21 22:09:53 2022 -0700 Bump `cloudbees-folder` from 6.708.ve61636eb_65a_5 to 6.714.v79e858ef76a_2 (#6391) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit bb01938ad8e4f239276df548043293ced25d32b4 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Mar 21 22:09:39 2022 -0700 Bump `display-url-api` from 2.3.5 to 2.3.6 (#6390) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 2ad5073a3946e6c8194c30724c480974bb0c26a3 Author: Basil Crow <me@basilcrow.com> Date: Mon Mar 21 11:20:30 2022 -0700 Add Java 17 to build/test matrix (#6364) commit 6f6cca1f8f4a9c535bd822c80cd2ad3cedff9cba Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun Mar 20 19:45:42 2022 -0700 Bump Script Security from 1140.vf967fb_efa_55a_ to 1145.vb_cf6cf6ed960 (#6387) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 8fa4231f18456eafd518f4bad5db913b71f74952 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun Mar 20 14:44:17 2022 -0700 Bump Jenkins Test Harness from 1721.v385389722736 to 1723.vcd938b_e66072 (#6388) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 181339fc778e602d0e326aae93d10ee6ebe29f1d Author: Basil Crow <me@basilcrow.com> Date: Sun Mar 20 12:43:52 2022 -0700 [JENKINS-67602] Recover from fingerprint corruption earlier (#6385) commit 86a37f8a6170e2344b61364abb2b2c7234840c40 Author: tploss <32729438+tploss@users.noreply.github.com> Date: Sun Mar 20 20:43:13 2022 +0100 [JENKINS-67964] Want access to temporarily offline cause (#6337) commit a9a4a04eb2e86bd65355e41cd2f8a3d360fedfed Author: Alex <mc.cache@web.de> Date: Sun Mar 20 20:42:28 2022 +0100 Fix encoding of security warnings in French (#6382) commit fff3bd3d2315da7a7a762894a5943c1418a6e6b7 Author: Basil Crow <me@basilcrow.com> Date: Thu Mar 17 16:02:58 2022 -0700 Support Java 17 in `Security637Test` (#6384) commit 6cf84863e38a1fa960979aeceb886098c5876c60 Author: Langer0416 <71805759+Langer0416@users.noreply.github.com> Date: Thu Mar 17 23:02:45 2022 +0800 [JENKINS-68037] "Add to view" checkbox is placed higher than the button next to it (#6381) commit 5aa0825c788cfa5a7a0112306ee3a552dcdadca5 Author: Basil Crow <me@basilcrow.com> Date: Thu Mar 17 08:00:18 2022 -0700 Stop serializing latch in `NodeProvisionerTest` (#6383) commit 422efe996e4ff1cb978cd108faeaf2360071d36f Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Wed Mar 16 23:02:46 2022 +0000 [JENKINS-67396] Update link and breadcrumb dropdowns (#6084) Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com> Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com> commit 1f9d51001e7615b45a808e5c1776a4f9862c3611 Author: Basil Crow <me@basilcrow.com> Date: Wed Mar 16 12:45:58 2022 -0700 Eliminate mocks from `ViewTest` (#6378) commit 18144e3e099cf7658360a9278060945401e071a0 Author: Alex <mc.cache@web.de> Date: Wed Mar 16 20:45:28 2022 +0100 Document modern progressive logging tag (#6377) commit 108abc84ea9dd979918d37adf8f93ba42877d7e8 Author: Alex <mc.cache@web.de> Date: Wed Mar 16 20:45:00 2022 +0100 Do not overflow on longer build names (#6363) commit 304c08a226c25235d06a192a2fccdc32399d90f6 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Mar 15 15:50:21 2022 -0700 Bump Stapler from 1642.ve454c4518974 to 1666.v0275e61a_9874 (#6376) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit e7287631c0dd40d7ac653a55958b586a4f1d4b99 Author: Basil Crow <me@basilcrow.com> Date: Tue Mar 15 15:49:59 2022 -0700 Remove unneeded profile (#6375) commit c2bc12fa9d8274f73b208ea432aec7feee5be0ed Author: Basil Crow <me@basilcrow.com> Date: Tue Mar 15 15:49:38 2022 -0700 Remove `NodeListTest` (#6374) commit 60995d46d9222413fa5779fa9c6c821c82c0288c Author: Basil Crow <me@basilcrow.com> Date: Tue Mar 15 15:49:15 2022 -0700 Assumptions in `XStream2EncodingTest` are not implemented correctly (#6373) commit 64fd019d7755cb18545033455c86a5b3381b715e Author: Langer0416 <71805759+Langer0416@users.noreply.github.com> Date: Wed Mar 16 06:23:24 2022 +0800 [JENKINS-67713] Align Polling Log "View as plain text" link with sidepanel (#6351) commit 0ed2779da308f0e881be41f904dc53ee8db8b4b0 Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Tue Mar 15 13:24:13 2022 +0000 [maven-release-plugin] prepare for next development iteration commit 34692330c5a00f0c07fdf27b27d45eb0752231d8 Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Tue Mar 15 13:23:44 2022 +0000 [maven-release-plugin] prepare release jenkins-2.339 commit 0d83b368f28cf273450ba62a1105f177adb620f1 Author: strangelookingnerd <49242855+strangelookingnerd@users.noreply.github.com> Date: Tue Mar 15 02:25:26 2022 +0100 [JENKINS-67953] Unavailable plugin label is not themeable (#6350) commit bfc1eb75c32b8ecc69f9e3a2365feef4ed1e71f2 Author: Basil Crow <me@basilcrow.com> Date: Mon Mar 14 18:24:28 2022 -0700 Restore original method signature of `CLICommand#getClientCharset` (#6370) commit 336173b689bb1f1187b7ead627871565e3f5c6a7 Author: Basil Crow <me@basilcrow.com> Date: Mon Mar 14 18:24:13 2022 -0700 Remove obsolete workaround for SUREFIRE-1588 (#6369) commit ee12b2df0b7ed7f92df7fa9595b2ec1650c0e210 Author: Basil Crow <me@basilcrow.com> Date: Mon Mar 14 18:23:50 2022 -0700 Remove `japicmp` (#6367) commit 0f40b2d0c227e7b52e09aee6fd0db9ab93781733 Author: Timka <35283270+bzzitsme@users.noreply.github.com> Date: Tue Mar 15 07:23:32 2022 +0600 Add Russian localization for Java 11 monitor (#6360) Co-authored-by: Temirlan Dyussyumbayev <bzzitsme@users.noreply.github.com> commit 84ddcc12629477acc2638f05d52926de803ad6dc Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Mar 14 07:31:35 2022 -0700 Bump `jenkins-test-harness` from 1712.v68cd645cb_f35 to 1721.v385389722736 (#6372) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit c2b4b09973afb84e42f0c2efb8b55723790fd8f2 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Mar 14 07:31:10 2022 -0700 Bump parent POM from 1.71 to 1.72 (#6371) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit d1f1839375f047f45ad4b545e77eb6f49b0629b6 Author: Basil Crow <me@basilcrow.com> Date: Mon Mar 14 07:30:51 2022 -0700 Forward compatibility with Java 17 Javadoc generation (#6368) commit 3bd3f1fec48648897529f67c44f0c4c100e99e12 Author: Basil Crow <me@basilcrow.com> Date: Mon Mar 14 07:30:28 2022 -0700 Remove unneeded Javadoc workarounds (#6366) commit c5f996a2ee5aa53e47480ebefb5f47899cf1e471 Author: Basil Crow <me@basilcrow.com> Date: Sun Mar 13 17:45:37 2022 -0700 Miscellaneous code cleanup (#6362) commit 49833ddc14a1161faaa28b6a7f3b96a4c3f13253 Author: Basil Crow <me@basilcrow.com> Date: Sun Mar 13 09:18:50 2022 -0700 Remove `-Dfile.encoding=UTF-8` from Surefire JVM arguments (#6365) commit 7ef4d94967348cd9b122df8dba68fc066f11d519 Author: Basil Crow <me@basilcrow.com> Date: Sat Mar 12 10:06:05 2022 -0800 Sort dependencies (#6357) commit aa3e18d18c748990cf411795def1a6f4015840da Author: kevinlin18 <7793728+kevinlin18@users.noreply.github.com> Date: Sun Mar 13 02:05:41 2022 +0800 Add Traditional Chinese translations (#6358) commit 9a45d8a35cc6bba299e1e4aae5a1149970d1fb38 Author: Alceu Rodrigues de Freitas Junior <glasswalk3r@yahoo.com.br> Date: Sat Mar 12 15:05:07 2022 -0300 Add missing Brazilian Portuguese translations (#6361) commit d3159330e7ac5217da867e23e0e96203611195cc Author: Stefan Spieker <S.Spieker@gmx.net> Date: Sat Mar 12 19:04:31 2022 +0100 Fix deprecation warnings and remove obsolete throws (#6335) commit 2a3597a2bf0c19d0219a43279243136fce33cf79 Merge: 938247e11c aa69e853c0 Author: Mark Waite <mark.earl.waite@gmail.com> Date: Sat Mar 12 06:03:33 2022 -0700 Merge pull request #6359 from basil/JENKINS-67995 [JENKINS-67995] `SystemdLifecycle` logging "Operation not permitted" calling `sd_notify(3)` during startup commit 938247e11c6de97e8d9af2dd3964a99716240418 Author: Vincent Latombe <vincent@latombe.net> Date: Fri Mar 11 16:02:08 2022 +0100 Update Winstone to 5.24 (#5928) commit 08a7881a99d519f1723b6435de93d87f7a00e27b Author: Basil Crow <me@basilcrow.com> Date: Fri Mar 11 07:00:42 2022 -0800 Add `Add-Opens` entry to `MANIFEST.MF` (#6356) commit aa69e853c06e266e8f4c11bd4b84562c661e9041 Author: Basil Crow <me@basilcrow.com> Date: Thu Mar 10 14:03:22 2022 -0800 `SystemdLifecycle` logging "Operation not permitted" calling `sd_notify(3)` during startup commit c772d810f6d3dc49771df55c3b791c9f1cd6d234 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Mar 10 08:20:54 2022 +0000 Bump matrix-project from 1.20 to 758.v7a_ea_491852f3 (#6354) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit a8c134fe88160b23196808e58d7b60e05425bc1c Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Mar 9 18:16:33 2022 -0800 Bump JUnit from 1.55 to 1.56 (#6353) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 1a495d8cd33b088ad36506b790075872c2844bbc Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Mar 9 18:16:13 2022 -0800 Bump `jenkins-test-harness` from 1706.v5257fc59612a_ to 1712.v68cd645cb_f35 (#6349) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 7e3f5c1d380efec5641ba2b3dcc821f0bc78df35 Author: Alex <mc.cache@web.de> Date: Wed Mar 9 21:08:15 2022 +0100 Improve appearance of the changeset box (#6343) commit b633ba5189067a4d16f730e5b7fc8d688b91fba7 Author: Basil Crow <me@basilcrow.com> Date: Wed Mar 9 12:07:47 2022 -0800 Deprecate `PosixException` in favor of `IOException` (#6345) commit f792e6501a6361cc6f60bcd2ba33573af653681d Author: Mark Waite <mark.earl.waite@gmail.com> Date: Wed Mar 9 13:07:33 2022 -0700 Search for `@since` only in specific source files (#6332) commit a25e123a360e14b34a7316462c8c5370f6c62651 Author: Alex <mc.cache@web.de> Date: Wed Mar 9 16:25:11 2022 +0100 Don't cut off letters on changeset view (#6344) commit ec3313db908ef91a348f6c0b6569e1a23ed1eb7e Author: Florian Berchtold <florian.berchtold@luminartech.com> Date: Wed Mar 9 07:24:52 2022 -0800 [JENKINS-67602] Skip corrupted fingerprint files (#6334) Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com> commit ca3c974b958457f71124400567eb483de3c2132b Author: Alceu Rodrigues de Freitas Junior <glasswalk3r@yahoo.com.br> Date: Wed Mar 9 12:24:24 2022 -0300 Update Brazilian Portuguese translations (#6346) commit eb22c1ac181a8d041d6a12ddbcd7114217c8995e Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Mar 9 07:23:52 2022 -0800 Bump Mockito from 4.3.1 to 4.4.0 (#6348) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit a1a82f670b0a0c49dfa6de2418d9c1ae348a6373 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Mar 8 18:08:57 2022 -0800 Bump Release Drafter from 5.18.1 to 5.19.0 (#6347) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 74402ca1e1b31c9b7aa1d028ad37e99dc86b819b Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Tue Mar 8 12:32:15 2022 +0000 [maven-release-plugin] prepare for next development iteration commit 7c0fdc4895973e087d839c8b9ca25a8a088ffd70 Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Tue Mar 8 12:31:22 2022 +0000 [maven-release-plugin] prepare release jenkins-2.338 commit 7618ae41ce64b64a79a3cb1cc4035a53e950eab8 Author: Markus Winter <m.winter@sap.com> Date: Tue Mar 8 09:10:26 2022 +0100 [JENKINS-59964] redirect to setOfflineCause (#6153) commit 643bd5889616142878cf75a1efd5784a3ebc588b Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Tue Mar 8 08:10:18 2022 +0000 [JENKINS-67965] Fix checkbox focus state (#6340) commit c06028667de29b186bc05be685498c1a20934660 Author: Basil Crow <me@basilcrow.com> Date: Tue Mar 8 00:10:07 2022 -0800 Stop overemphasizing console logs (#6342) commit b0e656824a9c2ffedbb051c62c5d882344588972 Author: Alex <mc.cache@web.de> Date: Tue Mar 8 09:09:40 2022 +0100 JENKINS-67858 Place ionicons at the same height as their associated text (#6341) commit e1e4864d201a87170ba6340d11f40d306d24e2dd Author: Alex <mc.cache@web.de> Date: Mon Mar 7 22:52:57 2022 +0100 Replace "unavailable" ionicon with a fixed size (#6291) commit 74b15d47ffdbec12927dd67835735eca80b44332 Author: Alex <mc.cache@web.de> Date: Mon Mar 7 22:52:43 2022 +0100 Use modern icons in workspace view of a job (#6229) commit 2696247bee9e05e6a15c415508924964f25646ca Author: Alex <mc.cache@web.de> Date: Mon Mar 7 17:14:57 2022 +0100 Only show one console box when viewing the build log (#6338) commit 0c4b79128d1c437955f62d8c4332301f28bb8615 Author: Alceu Rodrigues de Freitas Junior <glasswalk3r@yahoo.com.br> Date: Sun Mar 6 13:11:38 2022 -0300 Refactor `translation-tool.pl` (#6317) commit ee87e1e8692f597836316f4f9ae606b8faec986a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sat Mar 5 07:36:16 2022 -0800 Bump Remoting from 4.12 to 4.13 (#6329) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 7a97616501921451c776e6db1f61ce742d697734 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sat Mar 5 07:36:00 2022 -0800 Bump Awaitility from 4.1.1 to 4.2.0 (#6330) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit fa4e71edaa880e564dc2399a1e2b476fb408dd05 Author: Mark Waite <mark.earl.waite@gmail.com> Date: Sat Mar 5 08:35:43 2022 -0700 Update Javadoc `@since` for API additions (#6331) commit 5a3f295f44603f610b297ee7a67a0c9724388122 Author: Alceu Rodrigues de Freitas Junior <glasswalk3r@yahoo.com.br> Date: Sat Mar 5 12:35:25 2022 -0300 Removed unused Brazilian Portuguese properties (#6328) commit f3b8ad3d5c86f31734caae2be8e9d4c4f4d4c83a Author: Basil Crow <me@basilcrow.com> Date: Sat Mar 5 07:34:35 2022 -0800 Apply Perltidy to `translation-tool.pl` (#6326) commit ad72f4d9e3a360ca25a49d57f1a63b4ffe490592 Author: Denys Digtiar <ddigtiar@cloudbees.com> Date: Sun Mar 6 01:34:13 2022 +1000 Update `node` tag to say `built-in` instead of `builtin` (#6285) For consistency the default case of the `node` tag is changed to `built-in` in Jelly. No localization has been done so no message bundles are affected. commit de2517f5688790d93bf257fe666011c620db7c93 Author: Jesse Glick <jglick@cloudbees.com> Date: Fri Mar 4 10:35:50 2022 -0500 [JENKINS-66446] Adjust class loading behavior of `JnlpSlaveRestarterInstaller` (#6315) commit ad506f52f016e83b2f02d918e5ee65b1b243ba20 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Mar 3 12:22:01 2022 -0800 Bump actions/upload-artifact from 2.3.1 to 3 (#6327) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 99ae887070116d9f36c828c2b7aa9f2536216d0e Author: offa <bm-dev@yandex.com> Date: Thu Mar 3 15:09:54 2022 +0000 Add annotations as documented (#6325) commit 66cd7821d38cfdce93f0f3ff039c560a77db6c10 Author: Basil Crow <me@basilcrow.com> Date: Wed Mar 2 07:33:37 2022 -0800 Remove JNR (#6323) commit 0bbfcafa69e1743c9a44bbcb72215f1011bc9532 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Mar 2 07:33:16 2022 -0800 Bump Guava from 31.0.1 to 31.1 (#6322) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 7a167c4e7d7c388b4b6446ae7a6f4385bb334f36 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Mar 2 07:32:52 2022 -0800 Bump Matrix Authorization Strategy from 3.0.1 to 3.1 (#6321) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit f8959aea0e29f0eafffecc9690934b81a93c0e98 Author: Alceu Rodrigues de Freitas Junior <glasswalk3r@yahoo.com.br> Date: Wed Mar 2 12:31:30 2022 -0300 Add Brazilian Portuguese translation property files (#6319) commit 7301c641a87e517ed0acfe989264b50516b611c1 Author: Ikko Ashimine <eltociear@gmail.com> Date: Wed Mar 2 16:59:18 2022 +0900 Fix typo in datasource-debug.js (#6324) commit 07e3409f5e5e3d14a9d7770a8d5ff159c4f6b513 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Mar 1 20:38:32 2022 +0000 Bump actions/checkout from 2.4.0 to 3 (#6320) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 46603461e04e58b8627e754e6eec3fad59bb63f9 Author: Basil Crow <me@basilcrow.com> Date: Tue Mar 1 12:26:39 2022 -0800 Ignore Checkstyle 10.0 and later (#6318) commit 9472f1c96008164dbc7f4c205ad4e47ca0d81f81 Author: Zbynek Konecny <zbynek1729@gmail.com> Date: Tue Mar 1 18:04:59 2022 +0100 Allow missing logger name in log viewer (#6310) commit e863a9314a01ab48d0eab8df5d56c4c552f38f75 Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Tue Mar 1 12:27:00 2022 +0000 [maven-release-plugin] prepare for next development iteration commit d3db2711248b34e514ce4ea8d30f149935aa739a Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Tue Mar 1 12:26:39 2022 +0000 [maven-release-plugin] prepare release jenkins-2.337 commit 77af1bde9466f4265b1e58b078f83033b1d50ecf Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 28 08:06:19 2022 +0000 Bump script-security from 1138.v8e727069a_025 to 1140.vf967fb_efa_55a_ (#6314) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 053a313ac49940d430250a3c20065f5e776159e9 Author: Tim Jacomb <21194782+timja@users.noreply.github.com> Date: Sat Feb 26 15:10:51 2022 +0000 Persist changes made to boolean radio controls (#6311) commit 4d8be4795b90a1a188a97f18ba9d834ab2a39cda Author: Alceu Rodrigues de Freitas Junior <glasswalk3r@yahoo.com.br> Date: Sat Feb 26 12:10:24 2022 -0300 Remove unused Brazilian Portuguese localizations (#6309) commit ed588c88011d4c8b9cb7fee5541d0ac0d49bdd0f Author: Alceu Rodrigues de Freitas Junior <glasswalk3r@yahoo.com.br> Date: Sat Feb 26 12:10:03 2022 -0300 Add Brazilian Portuguese localizations (#6308) Co-authored-by: alceu.freitas <alceu.freitas@semantix.com.br> commit d065ac48f43b6e975426259d129603fd006869ef Author: kevinlin18 <7793728+kevinlin18@users.noreply.github.com> Date: Sat Feb 26 23:09:39 2022 +0800 Add Traditional Chinese localization for the setup wizard, signup, and login screens (#6302) commit e264124a58d7dbdadb71b1ccee38d99b796225be Author: Basil Crow <me@basilcrow.com> Date: Sat Feb 26 07:08:51 2022 -0800 Clarify that the changelog entry should be in the imperative mood (#6313) commit 7b543fedad09e4f3773f2ed609aea8ec63223bd8 Author: James Nord <jtnord@users.noreply.github.com> Date: Fri Feb 25 20:09:49 2022 +0000 [JENKINS-67885] update the bundled `display-url-api` plugin (#6305) commit d65044b88edce71054036dba1c4b90b680a1269b Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Feb 25 08:16:05 2022 -0800 Bump Spring Security from 5.6.1 to 5.6.2 (#6297) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 29f9a2b9d7afae65206850b6a4a109a7a07a3cb6 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Feb 24 19:52:43 2022 +0000 Bump script-security from 1131.v8b_b_5eda_c328e to 1138.v8e727069a_025 (#6301) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 292660d060a96aa115f988afecebd0587a1c5f89 Author: Alex <mc.cache@web.de> Date: Thu Feb 24 20:52:09 2022 +0100 Don't drop colors on active links (#6296) commit d8f39d52cbcc4d0229e298ad863422b8ab8ef2df Author: offa <bm-dev@yandex.com> Date: Thu Feb 24 19:51:54 2022 +0000 Add TimeZoneProperty getter (#6300) commit f430bc8c86abfe8cf7775bcfe468ec72b77a3a75 Author: Alceu Rodrigues de Freitas Junior <glasswalk3r@yahoo.com.br> Date: Thu Feb 24 08:54:58 2022 -0300 refactor: translation-tool.pl code formating with perltidy (#6290) commit 443d3a86f9e2427093f4ea0ad44fcc35ea2c6fad Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Thu Feb 24 08:46:38 2022 +0000 Remove the 'cloud configuration has moved to a separate configuration page' notice (#6298) commit e264f129faabf92f29ce10cf00ab761967b1cb65 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Thu Feb 24 08:46:26 2022 +0000 Update form bottom button bar appearance (#6295) Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com> commit 89c59b479b58fc6dcc31157ec5f6aa5d747e0b6c Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Tue Feb 22 12:30:50 2022 +0000 [maven-release-plugin] prepare for next development iteration commit 4c9a9be6154ab1cad7c3f0b7f282df66f5aeb150 Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Tue Feb 22 12:30:29 2022 +0000 [maven-release-plugin] prepare release jenkins-2.336 commit dbb6e2a76f975ca4ccf294a7cfb09e00bc801b2d Author: Basil Crow <me@basilcrow.com> Date: Mon Feb 21 23:00:19 2022 -0800 Revert "Remove JNR (#5979)" (#6299) This reverts commit 899d9fb584689a85f5c4f80e392d1314009529d4. commit 899d9fb584689a85f5c4f80e392d1314009529d4 Author: Basil Crow <me@basilcrow.com> Date: Mon Feb 21 12:23:45 2022 -0800 Remove JNR (#5979) commit 62430e74c337b1182a622f0fe0225162d1e56d41 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 21 10:49:05 2022 -0800 Bump Jenkins test harness from 1705.va_296493db_feb_ to 1706.v5257fc59612a_ (#6293) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 0607c2f9ca0f57c5b2eb0d56550e54ecc6e7fa96 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 21 10:48:37 2022 -0800 Bump Folders from 6.688.vfc7a_a_69059e0 to 6.708.ve61636eb_65a_5 (#6294) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 2681bb7ef5d5000aa17a7b4a02f865053c9de056 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 21 10:48:03 2022 -0800 Bump Spotless from 2.20.2 to 2.21.0 (#6292) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit f59c4b16c3871a19b54a25ca0fe07d312575309c Merge: 6ffba0f6e4 95d4d12442 Author: Mark Waite <mark.earl.waite@gmail.com> Date: Sun Feb 20 15:26:08 2022 -0700 Merge pull request #6284 from tullydwyer/manage-users-full-stop Add a full stop to the end of the Manage Users button description in the Manage Jenkins page commit 6ffba0f6e4a8048badd42b03c94ad8f85742e98b Merge: 904310a4f8 09e8d37867 Author: Mark Waite <mark.earl.waite@gmail.com> Date: Sun Feb 20 15:25:38 2022 -0700 Merge pull request #6289 from NotMyFault/fix/master/fix-console-icons Fix broken script- and console icon in agent view commit 904310a4f81938f0445d88ab6ccd3062edc48c89 Merge: 3fe3f76b18 940923d685 Author: Mark Waite <mark.earl.waite@gmail.com> Date: Sun Feb 20 15:24:41 2022 -0700 Merge pull request #6288 from benebsiny/JENKINS-67847 [JENKINS-67847] booleanRadio button is not shown correctly commit 3fe3f76b18af4ef68ee3046879c20503c082f232 Merge: ef7257a97e b4fa965a97 Author: Mark Waite <mark.earl.waite@gmail.com> Date: Sun Feb 20 15:24:17 2022 -0700 Merge pull request #6286 from NotMyFault/fix/master/fix-folder-icons [JENKINS-67823] Don't append leading slash to foreign icons commit ef7257a97ec60c966b851578b93b3aa1cb3cef88 Merge: acc79f984d 25d79617c8 Author: Mark Waite <mark.earl.waite@gmail.com> Date: Sun Feb 20 05:47:08 2022 -0700 Merge pull request #6287 from NotMyFault/fix/master/tooltip-nobuilt Don't show status tooltip on nobuilt jobs commit acc79f984d6f434c1291039da5dc2375ea59e037 Merge: 5e8aeafe67 c69c22f4fb Author: Mark Waite <mark.earl.waite@gmail.com> Date: Sun Feb 20 05:45:56 2022 -0700 Merge pull request #6283 from NotMyFault/fix/master/restore-labeled-agents [JENKINS-67837] Restore labeled agents view commit 5e8aeafe67a5828f08dce05dd6e5a0ba7dd3b690 Merge: a1378f109c dbeed62c0c Author: Mark Waite <mark.earl.waite@gmail.com> Date: Sat Feb 19 20:03:58 2022 -0700 Merge pull request #6279 from timja/theme-manager-integration Add selector for theme manager preview commit 09e8d37867b7f1de068f2629b90a8885ffe473ed Author: NotMyFault <mc.cache@web.de> Date: Sat Feb 19 17:15:05 2022 +0100 fix: Fix broken script- and console icon commit b4fa965a9711e0d13c5f50aaf82be4e475cef91b Merge: 45cb976292 a1378f109c Author: NotMyFault <mc.cache@web.de> Date: Sat Feb 19 13:13:47 2022 +0100 Merge branch 'master' into fix/master/fix-folder-icons commit 940923d685591043f621be4f4a48fe5144a80fbd Author: benebsiny <stu995106@hotmail.com.tw> Date: Sat Feb 19 18:28:40 2022 +0800 [JENKINS-67847] booleanRadio button is not shown correctly commit 25d79617c85622d04459512394f3de89d944db33 Author: NotMyFault <mc.cache@web.de> Date: Sat Feb 19 02:39:43 2022 +0100 fix: Don't show status tooltip on nobuilt jobs commit 45cb976292b6caabe5b748c87b476de2b9970dbc Author: NotMyFault <mc.cache@web.de> Date: Fri Feb 18 23:11:51 2022 +0100 Plugins may read icons from an URL commit a1378f109c006bec202d91548057457412455ff7 Merge: 01d997fc9a 9e4487cd1b Author: Mark Waite <mark.earl.waite@gmail.com> Date: Fri Feb 18 14:57:49 2022 -0700 Merge pull request #6282 from timja/t-summary JENKINS-67828 Don't prepend icon if it's already there commit 01d997fc9a91ddcc0816eefa563c6b5d735ea715 Merge: 1a807197ba 67c0f04a76 Author: Mark Waite <mark.earl.waite@gmail.com> Date: Fri Feb 18 14:57:21 2022 -0700 Merge pull request #6280 from NotMyFault/fix/master/register-help-icon Register help icon again commit 0bb9c4f0083c2e3ba83194388d2a04309bc8e33e Author: NotMyFault <mc.cache@web.de> Date: Fri Feb 18 22:01:35 2022 +0100 tests: Fix tests commit 74874f5380a62fb462f0db118cd723e9c72708d8 Author: NotMyFault <mc.cache@web.de> Date: Fri Feb 18 16:59:54 2022 +0100 fix: Don't append leading slash to foreign icons commit 95d4d12442a95c852a05e589c2ad0fd7a47240c2 Author: Tully Dwyer <tully1992@gmail.com> Date: Fri Feb 18 10:07:06 2022 +1000 add full stop to manage users description commit c69c22f4fb2688a020a0a7c27d90eeab0799c03f Author: NotMyFault <mc.cache@web.de> Date: Fri Feb 18 01:06:18 2022 +0100 fix: Restore labeled agents view commit 1a807197ba0c574c6f9c79803fcd1d5dc14fbf43 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Feb 17 13:25:43 2022 -0800 Bump Folders from 6.17 to 6.688.vfc7a_a_69059e0 (#6281) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 9e4487cd1bed584cbd70ea0482ec0dd6e4f3dd77 Author: Tim Jacomb <timjacomb1+github@gmail.com> Date: Thu Feb 17 21:02:37 2022 +0000 JENKINS-67828 Don't prepend icon if it's already there commit 67c0f04a763b46d69886bf57f95adba22f39bc69 Author: NotMyFault <mc.cache@web.de> Date: Thu Feb 17 09:17:59 2022 +0100 fix: Register help icon commit dbeed62c0c0e33c79d8335518c9b68442c7276e5 Author: Tim Jacomb <timjacomb1+github@gmail.com> Date: Wed Feb 16 20:26:55 2022 +0000 Add selector for theme manager preview commit 9db74daa0a9fd009a5d3725e96213d8bbc174908 Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Wed Feb 16 15:26:43 2022 +0000 [maven-release-plugin] prepare for next development iteration commit cdb52fdcf6a2a30ae73bc33a2cfd477728e4b44c Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Wed Feb 16 15:26:22 2022 +0000 [maven-release-plugin] prepare release jenkins-2.335 commit 958db3c0d39c5fc08bff9f4a7fcfd145333e2d3b Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Tue Feb 15 19:28:05 2022 +0000 Update Manage Jenkins icons (#6273) commit 595547e4e51863bfd85b32a1eafce5cc86542957 Author: Damian Szczepanik <damianszczepanik@users.noreply.github.com> Date: Mon Feb 14 21:50:08 2022 +0100 Add Polish translations for Jenkins plugin manager (#6275) commit af68f53240dc7a9d4bccf4e405e81a67cd62467a Author: Basil Crow <me@basilcrow.com> Date: Mon Feb 14 12:49:56 2022 -0800 Reduce usages of `StringUtils` (#6270) commit 6f5f7f644222d707a6abe0513412aba28459fc3f Author: Stefan Spieker <S.Spieker@gmx.net> Date: Sun Feb 13 21:00:21 2022 +0100 fixed some deprecation warnings (#6271) commit eecfbf2a338b7bff86847a2daea9ee4c9cbb361b Author: Stefan Spieker <S.Spieker@gmx.net> Date: Sun Feb 13 20:59:27 2022 +0100 Deprecate `Util.copyFile()` (#6272) * deprecate copyFile * Update core/src/main/java/hudson/Util.java Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com> Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com> commit 6071d5ab40a0acbfffb787e10cf048216eaff973 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sat Feb 12 08:51:55 2022 -0800 Bump parent POM from 1.70 to 1.71 (#6268) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 2c94b187dd4a8814dcdac7e6dd9a84fb16a5224d Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sat Feb 12 08:51:26 2022 -0800 Bump Jenkins Unit Test Harness from 1700.v6d3cd3101b_12 to 1705.va_296493db_feb_ (#6269) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit da2b31e76f901c3f85f1eb24c7f6d9fcc570f523 Author: Daniel Beck <1831569+daniel-beck@users.noreply.github.com> Date: Sat Feb 12 16:43:54 2022 +0100 Merge back test for 2022-02-09 release (#6266) Co-authored-by: Wadeck <wadeck.follonier@gmail.com> Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com> commit 684f65d56f87a4f950fb701639fc2d3fc67992af Author: Alex <mc.cache@web.de> Date: Sat Feb 12 16:43:48 2022 +0100 [JENKINS-67742] Replace computer-flash gif (#6254) commit 786a7fdb76af8ccb71812d43186b3a78e9cdf146 Author: Daniel Beck <1831569+daniel-beck@users.noreply.github.com> Date: Sat Feb 12 16:43:39 2022 +0100 Adapt to jenkinsci/remoting#490 (#5901) Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com> Co-authored-by: Basil Crow <me@basilcrow.com> commit 81072df4f7f3c0ecef0d5ab20100a87cb0acce58 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sat Feb 12 15:41:57 2022 +0000 Add support for Ionicons (symbols) to <l:Icon> and <l:task> components (#6186) commit 731a29786a2c9620240c4b0bee340c774d94852f Author: Alex <mc.cache@web.de> Date: Sat Feb 12 16:41:47 2022 +0100 Utilize new tables on fingerprints and expired tokens view (#6247) commit 14d420b6e8ebefc03ae7b85ba16f201beb8294ff Author: Alex <mc.cache@web.de> Date: Fri Feb 11 20:55:41 2022 +0100 [JENKINS-67753] Overwrite "grey" balls with modern build status (#6264) commit b97012a1f8e0968eb74c882b695673d7dc2cd559 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Thu Feb 10 22:37:16 2022 +0000 Polish forms components and split out CSS files (#6259) Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com> commit fb6f28bc023a3f1ab582cea355f9350893723498 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Feb 10 08:34:59 2022 -0800 Bump Remoting from 4.11.2 to 4.12 (#6261) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit fa9c4980720142c4dc99ade1606d56820aecf00f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Feb 10 08:33:54 2022 -0800 Bump Spotless from 2.20.1 to 2.20.2 (#6265) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit dedd42eadd97cf0f6fb2f0298d902c9617c5b358 Author: Basil Crow <me@basilcrow.com> Date: Wed Feb 9 10:04:35 2022 -0800 Winstone 5.22: Bump Jetty from 9.4.43.v20210629 to 9.4.45.v20220203 (#6262) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 414e7b0ade2b838929af3deb29ae0587c8b75894 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Feb 9 10:03:53 2022 -0800 Bump SLF4J from 1.7.35 to 1.7.36 (#6263) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 60731b16cd514d5be38319c716047bf75d6a3a04 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Feb 9 10:03:12 2022 -0800 Bump `jenkins-test-harness` from 1698.vc58b_4e102e41 to 1700.v6d3cd3101b_12 (#6260) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 6a1a552860a7036cb42969dff7268be69b2c762e Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Feb 9 10:02:40 2022 -0800 Bump Release Drafter from 5.18.0 to 5.18.1 (#6257) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 5661c1055d026424118e2488b84ea22a19bf423d Merge: 58a4259584 f008972874 Author: Daniel Beck <daniel-beck@users.noreply.github.com> Date: Wed Feb 9 14:31:52 2022 +0100 Merge remote-tracking branch 'jenkinsci/master' into master commit 58a4259584cf4281277132c855e3dbae0426b17d Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Tue Feb 8 00:22:41 2022 +0000 [maven-release-plugin] prepare for next development iteration commit 66d8747a57e13e1dc0f55ff01ce9273de254343c Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Tue Feb 8 00:22:17 2022 +0000 [maven-release-plugin] prepare release jenkins-2.334 commit f0089728741e3ebbf752f938b8bbd16d1e492b24 Author: Ikko Ashimine <eltociear@gmail.com> Date: Tue Feb 8 06:10:53 2022 +0900 Fix typo in event-debug.js (#6256) commit 0447d164d04aa63c77f0996a4505acfe35bb839e Author: Daniel Beck <1831569+daniel-beck@users.noreply.github.com> Date: Mon Feb 7 09:03:29 2022 +0100 Add a reminder to have Restricted or at-since in new public stuff (#6253) Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com> commit 608e41106eee52998287f58f7b0350bebefae9ba Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Mon Feb 7 08:03:23 2022 +0000 Update table styling and spacing (#6248) commit 280e38eb3abd7112d15a3e2e785471e81a02c63a Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Mon Feb 7 08:03:13 2022 +0000 Modernise form components (#5923) Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com> Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com> commit 7915d822cb84a6a17568dfdc55cfdb21c49dc97f Author: Daniel Beck <1831569+daniel-beck@users.noreply.github.com> Date: Sat Feb 5 14:07:29 2022 +0100 Note at-since from #6228 and #6237 (#6252) Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com> commit 8e6e1518e7b865ed95e6a13fb741fc4a5c03a9b2 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Feb 4 19:44:48 2022 +0000 Bump release-drafter/release-drafter from 5.17.6 to 5.18.0 (#6251) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 0bb63a9adfd4564c156af6e53fe8efdda342b023 Author: Basil Crow <me@basilcrow.com> Date: Fri Feb 4 03:48:34 2022 -0800 Clean up Javadoc for Java 17 (#6250) commit 8276aef4cc3dd81810fe6bdf6fa48141632c4636 Author: Wadeck Follonier <wadeck.follonier@gmail.com> Date: Fri Feb 4 00:53:50 2022 +0000 [SECURITY-2602] commit a95f84d7264996eb936eecffd86046d1bf01da44 Author: Alex <mc.cache@web.de> Date: Thu Feb 3 18:38:52 2022 +0100 Fix `/configure` link on custom log recorders (#6245) commit 9effdf611a1117a9fa5d1ee47765d0a7185878e3 Author: Daeho Ro <lamanus@outlook.kr> Date: Fri Feb 4 02:35:42 2022 +0900 Update the internalization of the build icon description for Korean (#6241) Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com> commit e39e69907905767bc3be115dcebd08d30e0056d3 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Feb 3 09:34:31 2022 -0800 Bump JUnit from 1.53 to 1.55 (#6246) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 01e1555d16b71608ce92f01420b3410d400118e9 Author: Basil Crow <me@basilcrow.com> Date: Wed Feb 2 08:29:07 2022 -0800 Remove unused deprecated method from `Listeners` (#6242) commit 3866e93a364c87594033ed4f2ca5b0ce69fedf9d Author: Basil Crow <me@basilcrow.com> Date: Wed Feb 2 08:28:52 2022 -0800 Extend startup notification timeout as each initialization milestone is attained (#6237) commit dd6c7074c143c6acd382e1cb79c40a5412f07e67 Merge: 2a4b628bef 11a1c98f64 Author: Mark Waite <mark.earl.waite@gmail.com> Date: Wed Feb 2 08:44:04 2022 -0700 Merge pull request #6233 from NotMyFault/fix/master/deduplicate-help-button Deduplicate help button question mark commit 2a4b628bef65b049da67bc77679131f765fa826c Merge: 55eb5b77ee 86be164df5 Author: Mark Waite <mark.earl.waite@gmail.com> Date: Wed Feb 2 08:40:59 2022 -0700 Merge pull request #6234 from timja/JENKINS-67689-hidden-cancel JENKINS-67689 Don't hide cancel button with long build names commit 55eb5b77ee0a084c443723af3f83ef89769ea71b Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Feb 1 20:47:11 2022 -0800 Bump `spotless-maven-plugin` from 2.20.0 to 2.20.1 (#6243) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 59ab7d299c87ab26afc2ab315686998f20f7b983 Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Tue Feb 1 12:27:44 2022 +0000 [maven-release-plugin] prepare for next development iteration commit f023108ec324d51d77da15890b2db8f1f76a61d3 Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Tue Feb 1 12:27:21 2022 +0000 [maven-release-plugin] prepare release jenkins-2.333 commit 86be164df5565b13fc4ec5dbc0d560d99e3a3a57 Author: Tim Jacomb <timjacomb1+github@gmail.com> Date: Mon Jan 31 09:06:35 2022 +0000 JENKINS-67689 Don't hide cancel button with long build names commit 1a42044347502c59cd9c39d1be67f654df02908a Author: Basil Crow <me@basilcrow.com> Date: Mon Jan 31 07:51:35 2022 -0800 Jenkins should terminate cleanly on `SIGTERM` (#6230) commit 405e97779732ccae7aefa7c47009bfd63394b20c Author: Basil Crow <me@basilcrow.com> Date: Mon Jan 31 07:51:23 2022 -0800 Notify `systemd(1)` about start-up completion and other service status changes (#6228) commit 42691956c50d40cd840b4d1f07ab43a1d9214a4f Author: Jesse Glick <jglick@cloudbees.com> Date: Mon Jan 31 10:50:56 2022 -0500 [JEP-7] Comment updates after removing JRuby support (#6224) commit 79e27f0a9e3b2def9f5f2958b04a9fc19b0bd4ce Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 31 10:59:04 2022 +0000 Bump xstream from 1.4.18 to 1.4.19 (#6231) Bumps [xstream](https://github.com/x-stream/xstream) from 1.4.18 to 1.4.19. - [Release notes](https://github.com/x-stream/xstream/releases) - [Commits](https://github.com/x-stream/xstream/commits) --- updated-dependencies: - dependency-name: com.thoughtworks.xstream:xstream dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 136b565fa34dfd863f4c6d973237692c26145b1f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun Jan 30 16:13:38 2022 -0800 Bump checkstyle from 9.2.1 to 9.3 (#6232) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 11a1c98f64f8bb12395eab329963277a72f3b46d Author: NotMyFault <mc.cache@web.de> Date: Sun Jan 30 23:55:51 2022 +0100 fix: Deduplicate help button question mark commit ee5176f183bf3286bab17ab3ed1dcde43f2f2e70 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun Jan 30 12:45:21 2022 +0000 Bump jenkins-test-harness from 1697.v6b_1e34cb_4ee6 to 1698.vc58b_4e102e41 (#6226) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit cb54d2fbbce6711d48af69dcc1c8b4d8d764ae3b Author: Daniel Beck <1831569+daniel-beck@users.noreply.github.com> Date: Sun Jan 30 13:45:10 2022 +0100 [JENKINS-67627] Have expandable text boxes expand into multiple lines (#6225) Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com> commit 691bc959c5b46b15c75e927935a93cd2c8026342 Author: NivKeidan <51288016+NivKeidan@users.noreply.github.com> Date: Sun Jan 30 10:40:47 2022 +0000 JENKINS-67635 consider agent label expressions when applying trimLabels (#6193) commit 1af49f99754a73e6f5a997f576a339a43d4bffe4 Author: Basil Crow <me@basilcrow.com> Date: Fri Jan 28 09:06:40 2022 -0800 Exclude newer versions of `tyrus-standalone-client-jdk` that require Java 11 (#6227) commit 4a7d59496b1abb68b9a10c5babeac12ad8506561 Author: Wadeck Follonier <Wadeck@users.noreply.github.com> Date: Fri Jan 28 12:03:08 2022 +0100 [JENKINS-67674] Update bundled dependencies after the advisory (#6180) Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com> commit 726c68cf5a6a29d53ba2cb177a66a28c43ae1f1a Author: EBIBO <stu995106@hotmail.com.tw> Date: Fri Jan 28 19:01:38 2022 +0800 [JENKINS-67496] Drag & drop is messed up, drag placeholders always have tiny size (#6184) commit adf23ab2e40d325aaa3ffefcfea0076dd8530bae Author: Basil Crow <me@basilcrow.com> Date: Thu Jan 27 08:56:22 2022 -0800 EOL support for JRuby (#6209) commit 58cf6fc0dfc93ed625733bf9e9477e8e57e0a9d2 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jan 27 08:53:07 2022 -0800 Bump `xmlunit.version` from 2.8.4 to 2.9.0 (#6218) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 50a4702f5920af4811edaa8385c7b39119d4ed70 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jan 27 09:22:51 2022 +0000 Bump jenkins-test-harness from 1692.v0a_3884e172a_4 to 1697.v6b_1e34cb_4ee6 (#6220) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit e63accb4d1ee1828475d72f33c8a8dac2645254b Author: James Nord <jtnord@users.noreply.github.com> Date: Thu Jan 27 09:21:56 2022 +0000 leave link to JENKINS-67681 (#6221) commit 382f9946ef118328327c1f929eba7f4b20af978f Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Thu Jan 27 09:21:19 2022 +0000 Remove assets that have been replaced with SVG versions (#5778) Co-authored-by: Basil Crow <me@basilcrow.com> commit 7efe0b3a05e542d56b8865e0b4b90f35782be823 Author: Basil Crow <me@basilcrow.com> Date: Thu Jan 27 01:20:35 2022 -0800 Clean up imports (#6217) commit 2e6e26c00b2b7c8f46e1cbcf26eb6749e75e2cdf Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jan 26 07:23:44 2022 -0800 Bump `stapler.version` from 1638.v229a_24fa_b_17c to 1642.ve454c4518974 (#6215) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 0ff2a8ddd7164f6aca12b83f44fe1bc71ce67728 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jan 26 07:21:53 2022 -0800 Bump `slf4jVersion` from 1.7.33 to 1.7.35 (#6216) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 2d453feeb885bd703f737103ffe880b4f08b1844 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jan 26 07:21:38 2022 -0800 Bump `jenkins-test-harness` (#6214) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit a14bf30bec5e7f60536f582bcc2e8138f9631e42 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jan 26 07:21:19 2022 -0800 Bump `mockito-inline` from 4.3.0 to 4.3.1 (#6213) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit b763d95929473fdcab1f9c7fc1d23cbac577e4a3 Author: James Nord <jtnord@users.noreply.github.com> Date: Wed Jan 26 15:20:49 2022 +0000 Deflake `Security400Test#ensureDoStopStillReachable` (#6212) commit 24da33ea332927c947fc369fc9bccc08103feabd Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 25 08:48:51 2022 -0800 Bump `mockito-inline` from 4.2.0 to 4.3.0 (#6208) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit f4fb9e84f8f352896f3bdda80082ee6c5ce202be Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 25 08:48:41 2022 -0800 Bump `matrix-auth` from 3.0 to 3.0.1 (#6207) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 4dd068ebec743ad196ff8990089eb68ab88a4318 Author: Daniel Beck <1831569+daniel-beck@users.noreply.github.com> Date: Tue Jan 25 17:48:22 2022 +0100 [JENKINS-67662] Do not show wrong feature name in tooltips (#6206) Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com> commit 9e73f5fa210b57d2af370ba39b4b3fafc0c0731f Author: Daniel Beck <1831569+daniel-beck@users.noreply.github.com> Date: Tue Jan 25 17:48:04 2022 +0100 Remove `publish-over-ssh` from setup wizard suggestions (#6205) Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com> commit ca77444aa191abb1463188218bc88452a93f0f5f Author: Daniel Beck <1831569+daniel-beck@users.noreply.github.com> Date: Tue Jan 25 17:47:50 2022 +0100 Add test to confirm bundled plugins don't have active warnings (#6204) Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com> commit c2cb1969af346a2f8eb657b5981f3c63da3fa05b Author: Tim Jacomb <21194782+timja@users.noreply.github.com> Date: Tue Jan 25 16:47:37 2022 +0000 JENKINS-56057 Support update site warnings with Configuration as Code (#6203) Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com> commit 565faf28f4b57349856633353ee411e8843d4efc Author: Wadeck Follonier <Wadeck@users.noreply.github.com> Date: Tue Jan 25 17:47:08 2022 +0100 Prevent one redirect in `AsynchPeople` (#6191) commit 812df00915017c45dfbc30bfe83b5411a2299e0a Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Tue Jan 25 12:29:12 2022 +0000 [maven-release-plugin] prepare for next development iteration commit df092cdfcf6042a2abe97c0f44c5fd43634fc0ba Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Tue Jan 25 12:28:51 2022 +0000 [maven-release-plugin] prepare release jenkins-2.332 commit 0cb248b6bc0152faef34ccd1ac35675e6f55062d Author: Tim Jacomb <21194782+timja@users.noreply.github.com> Date: Mon Jan 24 09:01:42 2022 +0000 Fix progress bar location (#6199) commit 708c2df7d2f82ef808381c2421f61a63cf372279 Merge: 612e606b8b e446fee206 Author: Mark Waite <mark.earl.waite@gmail.com> Date: Sat Jan 22 07:47:31 2022 -0700 Merge pull request #6189 from daniel-beck/test-UMOMNEE Confirm that UMOMNEE2 is translated to UMOMNEE in legacy API commit 612e606b8b9279d1a3ff2cd57752331aa3d0dc50 Merge: e5244691c7 a46a5a9cab Author: Mark Waite <mark.earl.waite@gmail.com> Date: Sat Jan 22 07:47:09 2022 -0700 Merge pull request #6196 from timja/fix-root-test-on-mac Fix UtilTest#createDirectoriesInRoot() on mac commit e5244691c760aeed105d46065813c11f7912c395 Merge: f5a18c5f18 1b5e5135db Author: Mark Waite <mark.earl.waite@gmail.com> Date: Sat Jan 22 07:46:42 2022 -0700 Merge pull request #6179 from offa/annotations Nullability annotations commit f5a18c5f183c8ede718f21e308dffea5d5bee336 Merge: 76ba3e1d82 163c2f70fa Author: Mark Waite <mark.earl.waite@gmail.com> Date: Sat Jan 22 07:45:50 2022 -0700 Merge pull request #6185 from Kevin-CB/merge-back-BuildAuthorizationTokenSEC2558Test Merge back BuildAuthorizationTokenSEC2558Test commit 76ba3e1d823d8517b6a781e8bf7bf06f802d5e95 Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Fri Jan 21 15:16:37 2022 +0000 [maven-release-plugin] prepare for next development iteration commit ecf6c6f287e0ed3962d3c2cceffdab84ae735cb1 Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Fri Jan 21 15:16:16 2022 +0000 [maven-release-plugin] prepare release jenkins-2.331 commit 2d6c654e2e4ea9b452c08bc5a6aad5094df6678b Author: Daniel Beck <1831569+daniel-beck@users.noreply.github.com> Date: Fri Jan 21 09:07:56 2022 +0100 Fix Javadoc of SCM#requiresWorkspaceForPolling (#6190) Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com> Co-authored-by: Basil Crow <me@basilcrow.com> commit 1b5e5135db735ba3c75fa3d9f68873a9a241b4fd Merge: d4393a3509 ba3c95855b Author: Basil Crow <me@basilcrow.com> Date: Thu Jan 20 16:32:12 2022 -0800 Merge remote-tracking branch 'origin/master' into annotations commit e446fee20604d235e711dfd297ce0e1e23bf5a5f Merge: 2b80a6e203 ba3c95855b Author: Basil Crow <me@basilcrow.com> Date: Thu Jan 20 16:30:39 2022 -0800 Merge remote-tracking branch 'origin/master' into test-UMOMNEE commit a46a5a9cab5b29aacf5817d39fddb15951050253 Merge: d617d9a767 ba3c95855b Author: Basil Crow <me@basilcrow.com> Date: Thu Jan 20 16:29:03 2022 -0800 Merge remote-tracking branch 'origin/master' into fix-root-test-on-mac commit ba3c95855b8a376de033a3cdce9a381ecfa48d95 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jan 20 16:28:08 2022 -0800 Bump `matrix-project` from 1.19 to 1.20 (#6178) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 95f716014469fce36eb666c77213696ca6d3c096 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jan 20 16:27:54 2022 -0800 Bump `spotless-maven-plugin` from 2.19.2 to 2.20.0 (#6182) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 43e053cac5d124d00c33cd4429cbf4a2f58109bf Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jan 20 16:27:38 2022 -0800 Bump `slf4jVersion` from 1.7.32 to 1.7.33 (#6183) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit d605e4e674188efbf911aa8cfb61cfa284b9e8ec Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jan 20 16:27:14 2022 -0800 Bump `release-drafter/release-drafter` from 5.15.0 to 5.17.6 (#6194) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 431546f5d84194bde0240fd754953b5e91192dcc Author: Basil Crow <me@basilcrow.com> Date: Thu Jan 20 16:25:00 2022 -0800 Revert "Bump `jenkins-test-harness` (#6173)" (#6195) This reverts commit 0a19e462385afa281712aee6b7c43ba5efd7deb0. commit d617d9a767c0cc58e146298ad27742b6b4287de8 Author: Tim Jacomb <timjacomb1+github@gmail.com> Date: Thu Jan 20 20:59:48 2022 +0000 Fix UtilTest#createDirectoriesInRoot() on mac commit 2b80a6e203f7c02fc2763b13e33715535f5e121f Author: Daniel Beck <daniel-beck@users.noreply.github.com> Date: Tue Jan 18 16:11:42 2022 +0100 Confirm that UMOMNEE2 is translated to UMOMNEE in legacy API commit 6edca13517f484e595f6f7341198239bc01ce8d5 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 18 08:20:07 2022 +0000 Bump mailer from 391.ve4a_38c1b_cf4b_ to 408.vd726a_1130320 (#6177) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 9d14ca692aed2d21616773908cfe355cdbb3ddf8 Author: Basil Crow <me@basilcrow.com> Date: Tue Jan 18 00:19:08 2022 -0800 Detach JavaMail (#6165) Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com> Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com> Co-authored-by: Jesse Glick <jglick@cloudbees.com> commit d4393a3509012468fee378fc1bda73a9c986546f Author: offa <bm-dev@yandex.com> Date: Mon Jan 17 07:24:29 2022 +0100 Fix possible null access commit 163c2f70fa772772ef8d40447b037e5923c7517c Author: Kevin-CB <kguerroudj@cloudbees.com> Date: Fri Jan 14 09:27:02 2022 +0100 Merge back BuildAuthorizationTokenSEC2558Test commit 15a8a2b02edc644d1658b1511013f357a3dae44c Author: offa <bm-dev@yandex.com> Date: Thu Jan 13 11:20:38 2022 +0100 Add nullability annotations commit 6b5e3d11700c086d9b3b6e14132240691a6bebbd Author: Zbynek Konecny <zbynek1729@gmail.com> Date: Thu Jan 13 08:46:54 2022 +0100 Unify labels in plugin manager (#6151) * Map outdated labels to canonical ones * Fix checkstyle issue (missing space) commit 70c92a5225dc4d2422ca5960a5c34c56af018577 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Thu Jan 13 07:46:28 2022 +0000 [JENKINS-67198] Increase width of forms (#6172) * Update theme.less * Update job config page width to match inner form components * Increase widths of form elements (roughly 100 pixels wider) commit 685b60ca0b141a7fe578e54eec03e31db4006916 Author: Basil Crow <me@basilcrow.com> Date: Wed Jan 12 15:26:51 2022 -0800 `LazyBuildMixInTest#newRunningBuildRelationFromPrevious` flaked on Windows (#6175) commit cd6da0fae6a7af02cb0dcf903d6d7c9d54d0744d Author: Daniel Beck <1831569+daniel-beck@users.noreply.github.com> Date: Thu Jan 13 00:26:39 2022 +0100 Documentation is no longer in the wiki (#6171) Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com> commit 0a19e462385afa281712aee6b7c43ba5efd7deb0 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jan 12 15:26:23 2022 -0800 Bump `jenkins-test-harness` (#6173) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 0eed2e5678a177a27bb7ecbc432a708b0328b5f6 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jan 12 15:25:49 2022 -0800 Bump `spotless-maven-plugin` from 2.19.1 to 2.19.2 (#6174) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 76ed4199331db4cca5b013d9ab9f6923dff8bf67 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jan 12 15:25:27 2022 -0800 Bump `antisamy-markup-formatter` from 2.6 to 2.7 (#6176) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 05eda5221a313f09c4e69351c447d755b1ff1f1f Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Tue Jan 11 17:10:30 2022 +0000 [maven-release-plugin] prepare for next development iteration commit 90b1b76fd25ef4704d054df8abd9dee26ebfe748 Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Tue Jan 11 17:10:08 2022 +0000 [maven-release-plugin] prepare release jenkins-2.330 commit 88736fbb20f2439dfd4366bb167934bfd2574b3a Merge: 1656ee796c 69f68ec05b Author: Daniel Beck <daniel-beck@users.noreply.github.com> Date: Tue Jan 11 15:27:11 2022 +0100 Merge branch 'security-master' into master commit 1656ee796cad7662d8f0dda0650d047e8878b514 Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Tue Jan 11 12:38:19 2022 +0000 [maven-release-plugin] prepare for next development iteration commit f3cbfa898de04c1c520a1cb5d15b5834785465c4 Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Tue Jan 11 12:37:23 2022 +0000 [maven-release-plugin] prepare release jenkins-2.329 commit 64d0f15ee577f8bf4c69641c4d135cc15fb971d7 Author: Tim Jacomb <21194782+timja@users.noreply.github.com> Date: Sat Jan 8 17:03:04 2022 +0000 Stop spamming logs when retrieving `AdminWhitelistRule` (#6128) commit bf81c201fbb71791ec9bbdf7d994d3c1abb51f36 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sat Jan 8 09:02:50 2022 -0800 Bump `spotless-maven-plugin` from 2.19.0 to 2.19.1 (#6169) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 936849e07d64a3783c4b7bfb75637d30588b2002 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sat Jan 8 09:02:27 2022 -0800 Bump `script-security` from 1118.vba21ca2e3286 to 1131.v8b_b_5eda_c328e (#6170) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 3b29e9d460381f83eba9e939f6053b8336d946f4 Author: Basil Crow <me@basilcrow.com> Date: Fri Jan 7 06:29:55 2022 -0800 Fix more `DM_DEFAULT_ENCODING` SpotBugs violations (#6098) commit 520e114ea1804c4eee594d30621f362413bfd60d Author: Basil Crow <me@basilcrow.com> Date: Fri Jan 7 06:29:39 2022 -0800 Use explicit character set in tests (#6150) commit dd0db180bf3fd727b5aa594a94105c3430004a84 Author: Basil Crow <me@basilcrow.com> Date: Fri Jan 7 06:29:06 2022 -0800 Begin migration to Jakarta Annotations (#6161) commit 72d38d2192ce46dfa29b1879bae2bc24b2b4c8ce Author: Jesse Glick <jglick@cloudbees.com> Date: Fri Jan 7 09:27:12 2022 -0500 Do not use `javax.mail` for `doCheckAdminAddress` (#6166) commit 46d6af94e6b767a6261b1db4760314372e193750 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Jan 7 06:26:57 2022 -0800 Bump `spotless-maven-plugin` from 2.18.0 to 2.19.0 (#6167) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 1c738297b02914a67f5ae42504cb3a24dcf4a753 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Jan 7 06:26:38 2022 -0800 Bump `jnr-posix` from 3.1.14 to 3.1.15 (#6168) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 5d9b1556ffe3fd54f45a9fa1571589d4714becaa Author: Jesse Glick <jglick@cloudbees.com> Date: Fri Jan 7 09:26:12 2022 -0500 [JENKINS-67470] Extend shading of Tyrus WebSocket client (#6164) commit 627912239e6c0e4324002d1bfd45e241b34127b3 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Fri Jan 7 11:41:58 2022 +0000 [JENKINS-67515] Fix vertical icon alignment for build status in M and S icon sizes (#6162) * JENKINS-67515 * Fix headlines commit 69f68ec05bf05459c5da78c94a7d7eec3022174d Merge: 8a30446847 b5c3764681 Author: Daniel Beck <daniel-beck@users.noreply.github.com> Date: Wed Jan 5 17:27:16 2022 +0100 Merge branch 'security-master' into master commit c31d9302d946463884406f920c8d14b2cf7cdf24 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jan 5 07:49:21 2022 -0800 Bump `jenkins` from 1.69 to 1.70 (#6158) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 02a975d5caac1e422ee082f18476e7ace91e0afd Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jan 5 07:49:07 2022 -0800 Bump `mailer` from 1.34 to 391.ve4a_38c1b_cf4b_ (#6159) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 6a3c64e320785e2e0e652678687b84e9a8bca478 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jan 5 07:48:51 2022 -0800 Bump `jenkins-test-harness` (#6160) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 7e8b5b37f76fe9e6d1a36eefbdc10e3d3c171477 Author: Basil Crow <me@basilcrow.com> Date: Tue Jan 4 09:01:13 2022 -0800 Remove `UG_SYNC_SET_UNSYNC_GET` SpotBugs exclusions (#6154) commit 4fb15e63b54e57bf95d88628515f73624c6c4cbf Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 4 09:01:01 2022 -0800 Bump `stapler.version` from 1627.v5c244c19f85f to 1635.vb_0ddedb_739f2 (#6156) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit f3e95ccec793dc97258c31d1e52ac704701dbdcd Author: Daniel Beck <1831569+daniel-beck@users.noreply.github.com> Date: Tue Jan 4 18:00:36 2022 +0100 Generalize compatibility warning for `compatibleSince` (#6157) Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com> commit 8a304468476221b854166468cdc7e4b0ad2358ec Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Tue Jan 4 12:23:25 2022 +0000 [maven-release-plugin] prepare for next development iteration commit 5480799adbe30d405e4525338115a98aafaa27f5 Author: Jenkins Release Bot <66998184+jenkins-release-bot@users.noreply.github.com> Date: Tue Jan 4 12:23:05 2022 +0000 [maven-release-plugin] prepare release jenkins-2.328 commit e27b310065b3c036b5fc9d123f1d1d99d3058c00 Author: Basil Crow <me@basilcrow.com> Date: Mon Jan 3 08:55:03 2022 -0800 Enable whitespace-related Checkstyle checks (#6149) commit 1068567cb4e7301b9bdca9d59edaee74763fc8fe Author: Tim Jacomb <21194782+timja@users.noreply.github.com> Date: Mon Jan 3 16:54:19 2022 +0000 Update caniuse db (#6155) `npx browserslist@latest --update-db` commit a07cc96c38461f6e7f622fb82a8f7e14d3baf16e Author: Basil Crow <me@basilcrow.com> Date: Mon Jan 3 08:53:21 2022 -0800 Mark `PollingResult` as `SerializableOnlyOverRemoting` (#6134) commit 12ad7a841d660393e7902f96af9bf599c46d53c9 Author: Basil Crow <me@basilcrow.com> Date: Sun Jan 2 08:16:03 2022 -0800 Remove unused import commit e61ade14e6b9945c9112e1c772695206a32cb961 Author: Basil Crow <me@basilcrow.com> Date: Sun Jan 2 08:08:25 2022 -0800 Fix remaining `MS_SHOULD_BE_FINAL` SpotBugs violations (#6141) commit f82d1677501635f7f320b8f9b344670a3dd5e00b Author: Basil Crow <me@basilcrow.com> Date: Sun Jan 2 08:07:37 2022 -0800 Fix `RV_RETURN_VALUE_IGNORED_BAD_PRACTICE` SpotBugs violations (#6135) commit 570093e08db15e2e53124ec20abde3c25bdc8f60 Author: Basil Crow <me@basilcrow.com> Date: Sun Jan 2 08:06:52 2022 -0800 Fix a `SE_BAD_FIELD` SpotBugs violation in `Job` (#6133) commit 57920c2aa195c217302d836bd88a39f37f7656f7 Author: Zbynek Konecny <zbynek1729@gmail.com> Date: Sun Jan 2 14:38:35 2022 +0100 Use SVG icons for agent context menu and executor st…
} | ||
|
||
StaplerRequest currentRequest = Stapler.getCurrentRequest(); | ||
currentRequest.getWebApp().getDispatchValidator().allowDispatch(currentRequest, Stapler.getCurrentResponse()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caused SECURITY-2777
} | ||
|
||
StaplerRequest currentRequest = Stapler.getCurrentRequest(); | ||
currentRequest.getWebApp().getDispatchValidator().allowDispatch(currentRequest, Stapler.getCurrentResponse()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caused SECURITY-2777
As part of this implementation, I've renamed references to the icon pack Ionicons to Symbol(s) - for example, previously you'd call
getIonicon(...)
, now you'd callgetSymbol(...)
.The way this implementation works is by using the existing classes/components and only extending/tweaking them where strictly necessary. I've spent a fair amount of time playing with different implementations (such as new classes/components/rewriting chunks of Icon related classes) and found that this was the easiest/simplest approach.
To use a symbol in your sidebar action or management screen item, you just need to reference the symbol name and prefix it with "symbol-", e.g. if you want to use the settings icon you'd do:
I've also added a translation layer (thanks to @NotMyFault for the idea!) that will translate traditional Tango icons into Jenkins Symbols automatically, so plugin developers can maintain backwards compatibility whilst also taking advantage of newer, modern symbols. There are currently five icons supported by the translation layer although I plan to add more in a later PR so as not to balloon this one up more.
As an example of Symbols support I've replaced the Settings icons across Jenkins with a new flat version, and I've also updated the Jenkins About icon. With the translation service, several other icons have changed automatically too - the build icon, the delete icon and the plugins icon.
I've also spent some time as part of this to look at how to clean up the Icon jelly code, I've moved it to Functions.java so that it isn't duplicated across
task.jelly
andmanage.jelly
.Once the
icon
andtask
components support Jenkins Symbols I'll open up follow up PRs to update icons across Jenkins - a WIP picture of the Manage Jenkins PR can be seen below:Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@timja
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are correctupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).