Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-69230] There is no space between the form and the button #6961

Merged
merged 2 commits into from
Aug 8, 2022
Merged

[JENKINS-69230] There is no space between the form and the button #6961

merged 2 commits into from
Aug 8, 2022

Conversation

ridemountainpig
Copy link
Contributor

@ridemountainpig ridemountainpig commented Aug 3, 2022

See JENKINS-69230.

Before

截圖 2022-08-03 下午10 58 44
截圖 2022-08-03 下午10 59 01

After

截圖 2022-08-03 下午11 06 17
截圖 2022-08-03 下午11 06 31

Proposed changelog entries

  • Add a space between repeating chunk items.

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO") if applicable.
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@NotMyFault NotMyFault added the bug For changelog: Minor bug. Will be listed after features label Aug 3, 2022
@NotMyFault NotMyFault changed the title JENKINS-69230 There is no space between the form and the button [JENKINS-69230] There is no space between the form and the button Aug 3, 2022
@NotMyFault NotMyFault requested a review from a team August 3, 2022 21:52
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on gitpod and compared to weekly.ci.jenkins.io, looks good.


/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@timja timja added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 4, 2022
@timja timja merged commit a523704 into jenkinsci:master Aug 8, 2022
krisstern pushed a commit to krisstern/jenkins that referenced this pull request Aug 14, 2022
…nkinsci#6961)

Co-authored-by: Alexander Brandes <mc.cache@web.de>
(cherry picked from commit a523704)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants