Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency css-minimizer-webpack-plugin to v4.2.0 #7190

Merged
merged 1 commit into from
Oct 1, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 29, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
css-minimizer-webpack-plugin 4.1.0 -> 4.2.0 age adoption passing confidence

Release Notes

webpack-contrib/css-minimizer-webpack-plugin

v4.2.0

Compare Source

Features

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code, used by dependency tooling skip-changelog Should not be shown in the changelog labels Sep 29, 2022
@renovate renovate bot requested a review from a team September 29, 2022 15:50
@timja
Copy link
Member

timja commented Sep 29, 2022

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 29, 2022
@renovate renovate bot force-pushed the renovate/css-minimizer-webpack-plugin-4.x branch 2 times, most recently from 9d6e9dd to 81fe290 Compare September 29, 2022 17:28
@NotMyFault NotMyFault removed the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 29, 2022
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revoking my approval for now, the build isn't clean on my local machine, nor is it on the ci.
Further investigation is needed.

Blocking review

@NotMyFault
Copy link
Member

Someone was already faster than I, this PR is blocked by webpack-contrib/css-minimizer-webpack-plugin#198

@renovate renovate bot force-pushed the renovate/css-minimizer-webpack-plugin-4.x branch from 81fe290 to 62c4368 Compare September 30, 2022 08:39
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now good to go. The issue has been fixed on jest's end, and renovate updated the transitive dependencies.

The build does no longer fail on the ci and my machine.

@NotMyFault NotMyFault added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 30, 2022
@basil basil merged commit 5f57c98 into master Oct 1, 2022
@basil basil deleted the renovate/css-minimizer-webpack-plugin-4.x branch October 1, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code, used by dependency tooling ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants