[JENKINS-68696] Remove javax.servlet:servlet-api
dependency
#7478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-68696.
https://github.com/jenkinsci/jenkins/blob/a4f9f5b64b441172f6a1d871a7c615c03ac26235/pom.xml#L115-L132= is a trick added in commit 982a8fa apparently to prevent plugins (and core?) from bundling Servlet API 2.x.
javax.servlet:servlet-api
has been banned through Enforcer in the plugin parent POM since jenkinsci/plugin-pom@a608967 and in the core parent POM since jenkinsci/pom@82f73fef, so it is longer necessary to keep this trick in core. Keeping it complicatesjenkinsci/jenkins/pom.xml
and our Dependabot configuration, so I think it is best to dispense with it from both the core dependency tree and the Dependendabot exclusions list and rely on the abovementioned Enforcer bans to keep it out of our dependency trees.Testing done
Proposed changelog entries
N/A
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).