Update appearance of keyboard shortcut tooltips

[janfaracik]

Small one in preparation for #7569. This PR adds a new component for showing keyboard shortcuts, it's currently used in the tooltip for search bars.

Screen.Recording.2023-08-25.at.21.29.41.mov

This will be used for the Command Palette button too, where hovering over the Search icon will list what shortcuts activate it.

Testing done

• Shortcut and animation display as expected

Proposed changelog entries

• N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[timja]

works nicely

[Kevin-CB]

Looks fine from a security perspective!

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[daniel-beck]

Is there a way to demonstrate the CMD/CTRL behavior? Right now it's unused code.

[daniel-beck]

It does not seem to be possible to define empty localizations. An attempt to do so will just use the default locale:

[janfaracik]

Good spot - updated.

[daniel-beck]

Subjective design feedback: The animation doesn't look good at the actual size. I first thought it was a bug, in particular on the default (non-dark) theme.

weird.animation.firefox.mov

[daniel-beck]

Still doesn't work for me.

(The build claims to be 2.434-SNAPSHOT so I'm not running the old one.)

Did you test this before resubmitting for review? If you did, what does the localized file look like?

[timja]

Still doesn't work for me. (The build claims to be 2.434-SNAPSHOT so I'm not running the old one.)

Did you test this before resubmitting for review? If you did, what does the localized file look like?

Works fine for me, there's a prefix and a suffix you need to update, I just fixed up a localisation (e.g. pl) as an example.

[timja]

@daniel-beck I like your single string approach, you happy with this?

[timja]

@daniel-beck you able to check this please?

[daniel-beck]

I didn't exactly provide a complete solution 😅

English localization is missing, so hovering just shows shortcut.

[daniel-beck]

Suggested change

	Optional message for the shortcut
	Tooltip message for the shortcut. Use the placeholder <code>{0}</code> escaped (wrapped in <code>&quot;</code>). A minimal message consisting of only the shortcut would be <code>&quot;{0}&quot;</code>.

(Assuming <code> works here.)

[timja]

it renders the code and &quot literally with the intellij plugin, unsure about stapler-maven-plugin itself, searching the code I couldn't see any handling of it though.

[janfaracik]

@daniel-beck @timja Updated this - big thanks to both of you for the comments and assistance.

[timja]

LGTM - tested the latest changes and reviewed the code, much more in line with what was expected and cleaner, thanks. Apologies for the delay

addressed

[timja]

Re-requested @NotMyFault review as the code has changed a fair bit since last approved.

@daniel-beck do you have an ETA / plan to review again?

Thanks

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[timja]

cc @NotMyFault ^^