-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Java 17 or newer #9358
Merged
Merged
Require Java 17 or newer #9358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotMyFault
approved these changes
Jun 8, 2024
timja
approved these changes
Jun 8, 2024
daniel-beck
approved these changes
Jun 11, 2024
core/src/main/java/jenkins/monitor/JavaVersionRecommendationAdminMonitor.java
Outdated
Show resolved
Hide resolved
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
This was referenced Jun 20, 2024
Merged
Merged
Closed
This was referenced Jun 20, 2024
Open
Merged
6 tasks
Added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-for-merge
The PR is ready to go, and it will be merged soon if there is no negative feedback
rfe
For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
upgrade-guide-needed
This changes might be breaking in rare circumstances, an entry in the LTS upgrade guide is needed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://groups.google.com/g/jenkinsci-dev/c/gsXAqOQQEPc/m/C_EIMal6BAAJ
This cannot be merged until after we ship the June 11 weekly. It is intended for the June 18 weekly. However, the code is ready right now.
Testing done
Tested that an appropriate error message was displayed when launching the WAR on Java 11.
Proposed changelog entries
Proposed upgrade guidelines
See this comment.
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist