Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Java 17 or newer #9358

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Require Java 17 or newer #9358

merged 5 commits into from
Jun 11, 2024

Conversation

basil
Copy link
Member

@basil basil commented Jun 7, 2024

https://groups.google.com/g/jenkinsci-dev/c/gsXAqOQQEPc/m/C_EIMal6BAAJ

This cannot be merged until after we ship the June 11 weekly. It is intended for the June 18 weekly. However, the code is ready right now.

Testing done

Tested that an appropriate error message was displayed when launching the WAR on Java 11.

Proposed changelog entries

  • Require Java 17 or newer.

Proposed upgrade guidelines

See this comment.

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@basil basil added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Jun 7, 2024
@timja
Copy link
Member

timja commented Jun 11, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jun 11, 2024
@timja timja merged commit 75f6c56 into jenkinsci:master Jun 11, 2024
16 checks passed
@basil
Copy link
Member Author

basil commented Aug 2, 2024

Added the upgrade-guide-needed label suggesting we include this information for envinject plugin users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted upgrade-guide-needed This changes might be breaking in rare circumstances, an entry in the LTS upgrade guide is needed
Projects
None yet
4 participants