Refine content and appearance of the user account screen

[janfaracik]

This pull request updates the content and minor styling of the user account screen to make the content a little cleaner and inline. This is part of an ongoing effort to simplify Jenkins' many forms.

Changes

• Reduced usages of the❓button in the form, preferably if help guidance is short, snappy and useful it should be displayed inline
• Refined content for 'Full name', 'Description', 'Console URL Provider' and 'User Defined Time Zone'
• UserPropertyDescriptor now has a getDescription() method that can be overridden - these descriptions will show on pages where supported
• Wrapped the form in the jenkins-form class to fix sizing
• Grouped the first two controls (name and description) in a section so that they display with a horizontal divider below

---

---

Before

---

After

Testing done

• User config page works as before

Proposed changelog entries

• Refine content and appearance of the user account screen.

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[janfaracik]

/label web-ui

[timja]

FYI something is wrong with your screenshots maybe transparency? in dark mode they are really messed up, and even in light mode if I open in a new tab they don't render right for me

[janfaracik]

FYI something is wrong with your screenshots maybe transparency? in dark mode they are really messed up, and even in light mode if I open in a new tab they don't render right for me

Should be fixed now, thanks!

[daniel-beck]

It is unusual for a descriptor to always have a single f:section, this might be the only form where that's actually the case. Given limited applicability (a single Descriptor here?) it seems unnecessary to extend Descriptor for this use case. Please demonstrate this is useful well beyond the descriptors and forms shown in this PR.

[janfaracik]

It is unusual for a descriptor to always have a single f:section, this might be the only form where that's actually the case. Given limited applicability (a single Descriptor here?) it seems unnecessary to extend Descriptor for this use case. Please demonstrate this is useful well beyond the descriptors and forms shown in this PR.

That's completely fair, I've moved it to UserPropertyDescriptor

obsolete

[timja]

LGTM, tested and all appears sensible.

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!