Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-71021] Lint failures do not print proper error message in local builds (regression in 2.359) #9761

Merged
merged 6 commits into from
Sep 22, 2024
Merged

[JENKINS-71021] Lint failures do not print proper error message in local builds (regression in 2.359) #9761

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
accf7e6
[JENKINS-71021] Lint failures do not print proper error message in lo…
basil Sep 19, 2024
f087124
Test 1
basil Sep 19, 2024
41d89bb
Test 2
basil Sep 19, 2024
4bf1c09
Test 3
basil Sep 19, 2024
4cc55af
Testing is finished
basil Sep 19, 2024
c2c0eef
Merge branch 'master' into JENKINS-71021
basil Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
126 changes: 57 additions & 69 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,70 +421,6 @@ THE SOFTWARE.
<changelog.url>https://www.jenkins.io/changelog-stable</changelog.url>
</properties>
</profile>
<profile>
<id>yarn-ci-lint</id>
<activation>
<property>
<name>env.CI</name>
</property>
<file>
<exists>package.json</exists>
</file>
</activation>
<build>
<plugins>
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
<version>1.15.0</version>
<executions>
<execution>
<id>yarn lint:ci</id>
<goals>
<goal>yarn</goal>
</goals>
<configuration>
<arguments>lint:ci</arguments>
<skip>${yarn.lint.skip}</skip>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>yarn-lint</id>
<activation>
<property>
<name>!env.CI</name>
</property>
<file>
<exists>package.json</exists>
</file>
</activation>
<build>
<plugins>
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
<version>1.15.0</version>
<executions>
<execution>
<id>yarn lint</id>
<goals>
<goal>yarn</goal>
</goals>
<configuration>
<arguments>lint</arguments>
<skip>${yarn.lint.skip}</skip>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>yarn-execution</id>
<activation>
Expand Down Expand Up @@ -526,7 +462,6 @@ THE SOFTWARE.
<artifactId>frontend-maven-plugin</artifactId>
<version>1.15.0</version>
<executions>

<execution>
<id>install node and yarn</id>
<goals>
Expand All @@ -540,15 +475,13 @@ THE SOFTWARE.
<!-- tried to create a mirror for yarnDownloadRoot but it did not work -->
</configuration>
</execution>

<execution>
<id>yarn install</id>
<goals>
<goal>yarn</goal>
</goals>
<phase>initialize</phase>
</execution>

<execution>
<id>yarn build</id>
<goals>
Expand All @@ -559,12 +492,34 @@ THE SOFTWARE.
<arguments>build</arguments>
</configuration>
</execution>

</executions>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>yarn-ci-lint</id>
<activation>
<property>
<name>env.CI</name>
</property>
<file>
<exists>package.json</exists>
</file>
</activation>
<build>
<plugins>
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
<version>1.15.0</version>
<executions>
<execution>
<id>yarn lint</id>
Copy link
Member Author

@basil basil Sep 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear why there were three linting executions; there is only a need for two (one for CI, and one for local builds). Deleted the unnecessary execution and moved the two necessary executions to the correct place in the file (after the build executions, reflecting the order of operations at runtime).

<id>yarn lint:ci</id>
<goals>
<goal>yarn</goal>
</goals>
<phase>test</phase>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed in order to get CI builds to honor

jenkins/Jenkinsfile

Line 96 in 57d8fa0

'-Dmaven.test.failure.ignore',
to address https://issues.jenkins.io/browse/JENKINS-71021?focusedId=448486&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-448486 (cf. https://github.com/eirslett/frontend-maven-plugin/blob/f39b40c20971ecb810adce465d37f28d9dc4c0e6/frontend-maven-plugin/src/main/java/com/github/eirslett/maven/plugins/frontend/mojo/AbstractFrontendMojo.java and also jenkinsci/plugin-pom#874).

<configuration>
<arguments>lint:ci</arguments>
<skip>${yarn.lint.skip}</skip>
Expand All @@ -575,6 +530,39 @@ THE SOFTWARE.
</plugins>
</build>
</profile>
<profile>
<id>yarn-lint</id>
<activation>
<property>
<name>!env.CI</name>
</property>
<file>
<exists>package.json</exists>
</file>
</activation>
<build>
<plugins>
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
<version>1.15.0</version>
<executions>
<execution>
<id>yarn lint</id>
<goals>
<goal>yarn</goal>
</goals>
<phase>test</phase>
<configuration>
<arguments>lint</arguments>
<skip>${yarn.lint.skip}</skip>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>

<profile>
<id>clean-node</id>
Expand Down
Loading